Page MenuHomeFreeBSD
Differential D51416

nvme: Move AER processing into a task thread
ClosedPublic
Actions

Authored by imp on Jul 18 2025, 11:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 4:39 AM
Unknown Object (File)
Tue, Sep 8, 7:12 AM
Unknown Object (File)
Fri, Sep 4, 4:41 AM
Unknown Object (File)
Fri, Sep 4, 4:37 AM
Unknown Object (File)
Thu, Sep 3, 6:08 PM
Unknown Object (File)
Thu, Sep 3, 5:42 PM
Unknown Object (File)
Thu, Sep 3, 5:21 PM
Unknown Object (File)
Thu, Sep 3, 3:19 PM
View All 78 Files
Subscribers
dab

Details

Reviewers
jhb
mav
chs
chuck
ken
imp
Summary

Move the AER processing into the taskqueue thread. We do memory
allocations and such burried deep in things we call, so this just makes
all that simpler and doesn't stall the completion thread. It fixes a few
panics if you get a reliability failure from the drive at the wrong
time.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65572
Build 62455: arc lint + arc unit

Event Timeline

imp created this revision.Jul 18 2025, 11:10 PM
Herald added a subscriber: dab. · View Herald TranscriptJul 18 2025, 11:10 PM
imp requested review of this revision.Jul 18 2025, 11:10 PM
Harbormaster completed remote builds in B65572: Diff 158765.Jul 18 2025, 11:10 PM
imp added a parent revision: D51415: nvme: Finish removing failed request queue.Jul 18 2025, 11:10 PM
imp added a comment.Jul 18 2025, 11:12 PM

We see about 1-3 crashes a month from this from our fleet of NVMe drives at work...

imp added inline comments.Jul 18 2025, 11:17 PM
sys/dev/nvme/nvme_ctrlr.c
1176

For the record, I think we shouldn't be doing this byte swapping and should use the appropriate leXXtohost() functions where we use the data, but that's a bigger change for another day. Also, I don't have BE hardware to test this on.

jhb added a comment.Jul 23 2025, 7:08 PM

nvmf already uses a taskqueue for this for the same reasons.

imp added a comment.Jul 23 2025, 7:46 PM
In D51416#1175601, @jhb wrote:

nvmf already uses a taskqueue for this for the same reasons.

Yea, I need to close this since I'd accidentally pushed this when I was pushing other changes.

imp accepted this revision.Jul 23 2025, 7:48 PM

This landed in b21e67875bf0c4b1e7933090b80307abb24b7d03 (by mistake, so no autoclose)

This revision is now accepted and ready to land.Jul 23 2025, 7:48 PM
imp closed this revision.Jul 23 2025, 7:48 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
289 lines
2 lines

Diff 158765

View Options

sys/dev/nvme/nvme_ctrlr.c

Loading...
View Options

sys/dev/nvme/nvme_private.h

Loading...