Page MenuHomeFreeBSD
Differential D51253

pmap: Degrade pmap_page_set_attr*() into a no-op on same attribute
ClosedPublic
Actions

Authored by olce on Jul 11 2025, 7:27 AM.
Tags
None
Referenced Files
F127680406: D51253.diff
Wed, Sep 3, 12:40 PM
Unknown Object (File)
Mon, Aug 18, 10:50 AM
Unknown Object (File)
Wed, Aug 13, 1:39 PM
Unknown Object (File)
Thu, Aug 7, 8:28 PM
Unknown Object (File)
Tue, Aug 5, 11:27 AM
Unknown Object (File)
Tue, Aug 5, 12:44 AM
Unknown Object (File)
Aug 3 2025, 9:28 AM
Unknown Object (File)
Aug 2 2025, 1:39 AM
View All 17 Files
Subscribers
emaste
imp
jeffpc_josefsipek.net
jhibbits
riscv

Details

Reviewers
kib
markj
andrew
manu
Commits
rG0e9a3bdeb737: pmap: Degrade pmap_page_set_attr*() into a no-op on same attribute
rG9d1f3ce79d85: pmap: Degrade pmap_page_set_attr*() into a no-op on same attribute
Summary

For 32-bit arm, move the no-op test that was already in place at start
of the function so that it stays first even if the '#if 0' block around
the call to sf_buf_invalidate_cache() is uncommented at some point (if
ever).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65346
Build 62229: arc lint + arc unit

Event Timeline

olce created this revision.Jul 11 2025, 7:27 AM
Herald added a reviewer: andrew. · View Herald TranscriptJul 11 2025, 7:27 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript
olce requested review of this revision.Jul 11 2025, 7:27 AM
Harbormaster completed remote builds in B65346: Diff 158314.Jul 11 2025, 7:27 AM
jeffpc_josefsipek.net added a subscriber: jeffpc_josefsipek.net.Jul 11 2025, 10:48 AM

As a non-expert on the code, LGTM (assuming there aren't some special rules about read-write accesses to the saved attributes).

sys/powerpc/aim/mmu_radix.c
5942

Trivial nit: other files got an extra empty line after the if-return.

kib accepted this revision.Jul 12 2025, 6:03 PM
This revision is now accepted and ready to land.Jul 12 2025, 6:03 PM
olce closed this revision.Jul 13 2025, 8:39 AM
olce added a commit: rG9d1f3ce79d85: pmap: Degrade pmap_page_set_attr*() into a no-op on same attribute.
olce marked an inline comment as done.
olce added a commit: rG0e9a3bdeb737: pmap: Degrade pmap_page_set_attr*() into a no-op on same attribute.Jul 28 2025, 8:49 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
5 lines
arm/
arm/
32 lines
arm64/
arm64/
2 lines
i386/
i386/
2 lines
powerpc/
aim/
3 lines
3 lines
3 lines
riscv/
riscv/
2 lines

Diff 158314

View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/arm/arm/pmap-v6.c

Loading...
View Options

sys/arm64/arm64/pmap.c

Loading...
View Options

sys/i386/i386/pmap.c

Loading...
View Options

sys/powerpc/aim/mmu_oea.c

Loading...
View Options

sys/powerpc/aim/mmu_oea64.c

Loading...
View Options

sys/powerpc/aim/mmu_radix.c

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...