Page MenuHomeFreeBSD
Differential D51095

Add sched_getaffinity.3 to document sched_getaffinity and sched_setaffinity
AbandonedPublic
Actions

Authored by felix.the.red_gmail.com on Jun 30 2025, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 12:59 AM
Unknown Object (File)
Wed, Aug 12, 11:37 PM
Unknown Object (File)
Wed, Aug 12, 9:19 PM
Unknown Object (File)
Wed, Aug 12, 6:09 PM
Unknown Object (File)
Mon, Aug 10, 9:30 PM
Unknown Object (File)
Mon, Aug 10, 10:40 AM
Unknown Object (File)
Mon, Aug 10, 10:14 AM
Unknown Object (File)
Mon, Aug 10, 10:04 AM
View All 90 Files
Subscribers
imp
kib
pauamma_chezdork.com
ziaee

Details

Reviewers
None
Group Reviewers
manpages
Summary

The sched_getaffinity(3) and sched_setaffinity(3) functions added in FreeBSD 13.1 lack a manual page.
This revision creates a manual page to document those functions.

The original PR mentions sched_getcpu and sched_getaffinity.
A manual page exists for the first one, sched_getcpu(3).

PR:265249

Test Plan

mandoc -Tlint
Read lib/libc/gen/sched_getaffinity.c and lib/libc/gen/sched_setaffinity.c.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

felix.the.red_gmail.com created this revision.Jun 30 2025, 8:27 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptJun 30 2025, 8:27 PM
felix.the.red_gmail.com requested review of this revision.Jun 30 2025, 8:27 PM
pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.Jul 1 2025, 1:05 AM
  • English and markup both look good to me at a glance, but I can't attest to consistency with source code
  • I think you also need to add to MLINKS in the appropriate Makefile so "man sched_setaffinity" will work
ziaee added inline comments.Jul 1 2025, 1:32 AM
lib/libsys/sched_getaffinity.3
2

There's a blank comment before this line also

12

Nd is lowercase

kib added a subscriber: kib.Jul 1 2025, 3:17 AM
kib added inline comments.
lib/libsys/sched_getaffinity.3
51

This is confusing, I do not understand what are you trying to say there.

The pid parameter might be actual pid, or it might be tid. If it is pid, some random thread in the target process is selected, and its cpuset is returned. If it is tid, the specified thread' cpuset is returned.

kib added inline comments.Jul 1 2025, 3:29 AM
lib/libsys/sched_getaffinity.3
51

And I am wrong about pid. If pid is specified, the masks of all threads in the process are OR-ed for the result. It is not a mask of single random thread.

ziaee added inline comments.Jul 1 2025, 4:23 AM
lib/libsys/sched_getaffinity.3
13

Section 3 manuals need a Lb macro

felix.the.red_gmail.com updated this revision to Diff 157861.Jul 2 2025, 9:43 PM

Clarify the use of sched_getaffinity, sched_setaffinity,
the value of the pid parameter and how it differs
between the functions, and their return values.
Add an entry in Makefile.sys to include the manual page
in the build.

ziaee added inline comments.Jul 2 2025, 10:13 PM
lib/libsys/sched_getaffinity.3
12

.Sh LIBRARY is deprecated, please put .Lb in the SYNOPSIS

ziaee added inline comments.Jul 2 2025, 10:52 PM
lib/libsys/Makefile.sys
494

(Or something, typing this on my phone while driving)

felix.the.red_gmail.com updated this revision to Diff 157866.Jul 3 2025, 12:59 AM
felix.the.red_gmail.com marked 3 inline comments as done.

sched_getaffinity.3: Move library section.
Makefile.sys: Add MLINKS

felix.the.red_gmail.com marked 4 inline comments as done.Jul 3 2025, 1:00 AM

Updated to address clarity and formatting.

kib added a comment.Jul 3 2025, 3:43 AM

Why the man page added to libsys? It must go into libc/gen.

lib/libsys/sched_getaffinity.3
22

I do not think that this .Pp is needed. We do not do this in other multi-function man pages.

33

I suggest to move this sentence somewhere near the end of DESCRIPTION.
It is a useful info to know, but not the first thing a reader interested in the function needs to see.

46

No, this is again not right.
If pid > 0 and pid < PID_MAX, then the description is correct.
Otherwise pid is really tid and then the mask of the named thread is returned.

57

No, it is either pid or tid, as above.

60

No, if pid is pid, the mask is applied to all threads of the target process.
If pid is tid, the mask is applied to the specified thread.

felix.the.red_gmail.com abandoned this revision.Jul 7 2025, 5:38 PM

I will move everything to libc and fix issues in a separate commit.

ziaee added a comment.EditedJul 7 2025, 9:19 PM
In D51095#1168792, @felix.the.red_gmail.com wrote:

I will move everything to libc and fix issues in a separate commit.

  1. Please do not do this in the future, it makes us loose the state, participants, and difficult to follow the history. You can always fix the review. If you have any questions about git or Phabricator, just ask, I'd be honored to help. Everything I know I learned from other people in this project.
  1. Since you did, please comment linking that review to this one, and this review to that one, and add everyone who was in this discussion.

Edit: but don't feel bad about it everyone does it. When I first started I ended up closing and starting a new review four times!

Revision Contents
Changeset List

PathSize
lib/
libsys/
1 line
89 lines

Diff 157861

View Options

lib/libsys/Makefile.sys

Loading...
View Options

lib/libsys/sched_getaffinity.3

Loading...