Page MenuHomeFreeBSD
Differential D50214

arm64: Reduce where we decode msr/mrs instructions
ClosedPublic
Actions

Authored by andrew on May 6 2025, 5:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 26, 5:43 PM
Unknown Object (File)
Wed, Aug 26, 5:42 PM
Unknown Object (File)
Mon, Aug 24, 3:35 AM
Unknown Object (File)
Thu, Aug 13, 9:16 PM
Unknown Object (File)
Wed, Aug 12, 3:37 PM
Unknown Object (File)
Tue, Aug 11, 4:12 PM
Unknown Object (File)
Sat, Aug 8, 5:32 PM
Unknown Object (File)
Fri, Aug 7, 7:53 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
manu
harry.moulton_arm.com
Group Reviewers
arm64
Commits
rGb47a6c93e262: arm64: Reduce where we decode msr/mrs instructions
Summary

We only use the mrs_Op* and mrs_CR* functions and MRS_* macros when
handling userspace executing a msr/msr instruction.

Move the macros to where they are used and expand the functions to
just use the macros directly.

While here update MRS_Op0_MASK to include bit 20 as this will cause
the correct op0 value to be calculated for all instructions we decode.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64941
Build 61824: arc lint + arc unit

Event Timeline

andrew created this revision.May 6 2025, 5:05 PM
Herald added a reviewer: manu. · View Herald TranscriptMay 6 2025, 5:05 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.May 6 2025, 5:05 PM
Harbormaster completed remote builds in B63963: Diff 154975.May 6 2025, 5:05 PM
andrew added a parent revision: D50213: arm64: Use a sys handler for CTR_EL0.May 6 2025, 5:05 PM
harry.moulton_arm.com accepted this revision.May 9 2025, 3:30 PM
This revision is now accepted and ready to land.May 9 2025, 3:30 PM
andrew edited the summary of this revision. (Show Details)Jun 17 2025, 1:25 PM
andrew added a parent revision: D50906: arm64: Remove the MRS_REG macro and it's users.
andrew updated this revision to Diff 157177.Jun 17 2025, 1:26 PM

Rebase on D50906 to move all MRS_ macros to undefined.c

This revision now requires review to proceed.Jun 17 2025, 1:26 PM
Harbormaster completed remote builds in B64941: Diff 157177.Jun 17 2025, 1:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 23 2025, 12:08 PM
Closed by commit rGb47a6c93e262: arm64: Reduce where we decode msr/mrs instructions (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGb47a6c93e262: arm64: Reduce where we decode msr/mrs instructions.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
49 lines
include/
19 lines
20 lines

Diff 157177

View Options

sys/arm64/arm64/undefined.c

Loading...
View Options

sys/arm64/include/armreg.h

Loading...
View Options

sys/arm64/include/undefined.h

Loading...