Page MenuHomeFreeBSD
Differential D50204

arm64: Remove an old workaround
ClosedPublic
Actions

Authored by andrew on May 6 2025, 5:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 11, 4:34 AM
Unknown Object (File)
Mon, Jul 7, 7:30 AM
Unknown Object (File)
Sun, Jul 6, 6:53 PM
Unknown Object (File)
Fri, Jul 4, 7:27 PM
Unknown Object (File)
Fri, Jul 4, 4:45 PM
Unknown Object (File)
Thu, Jul 3, 5:19 PM
Unknown Object (File)
Jun 16 2025, 10:29 AM
Unknown Object (File)
May 31 2025, 12:04 AM
View All 19 Files
Subscribers
emaste
imp

Details

Reviewers
manu
harry.moulton_arm.com
emaste
imp
Group Reviewers
arm64
Commits
rG10a93c92c40a: arm64: Remove an old workaround
Summary

This is an old workaround for an instruction that wasn't emulated
correctly on QEMU prior to 2.5.1. As we now read more ID registers that
should also hit this bug trapping this register, and not the others we
can assume nobody hits this anymore.




Sponsored by:   Arm Ltd
Diff Detail
Repository 
rG FreeBSD src repository 
Lint 
Lint Not Applicable
 
Unit 
Tests Not Applicable
 
Event Timeline
andrew created this revision.May 6 2025, 5:03 PM
Herald added a reviewer: manu.  ·  View Herald TranscriptMay 6 2025, 5:03 PM
Herald added subscribers: emaste, imp.  ·  View Herald Transcript
andrew requested review of this revision.May 6 2025, 5:03 PM
Harbormaster completed remote builds in B63953: Diff 154965.May 6 2025, 5:03 PM
andrew added a parent revision: D50203: arm64: Raise a SIGILL if we fail reading an insn.May 6 2025, 5:03 PM
andrew added a child revision: D50205: arm64: Remove kernel undef instruction support.
emaste added a comment.May 6 2025, 5:23 PM
IMO it's worth including in the commit message the context from the now-removed comment "QEMU prior to 2.5.1"
andrew edited the summary of this revision. (Show Details)May 9 2025, 2:50 PM
harry.moulton_arm.com accepted this revision.May 9 2025, 3:25 PM
This revision is now accepted and ready to land.May 9 2025, 3:25 PM
emaste accepted this revision.May 9 2025, 4:29 PM
imp accepted this revision.May 9 2025, 4:41 PM
Closed by commit rG10a93c92c40a: arm64: Remove an old workaround (authored by andrew).  ·  Explain WhyMay 12 2025, 12:50 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG10a93c92c40a: arm64: Remove an old workaround.
Revision Contents
Changeset List
PathSize
sys/
arm64/
arm64/
31 lines
Diff 155315
View Options
sys/arm64/arm64/undefined.c
Loading...