gssd: Add support for MIT KRB5
ClosedPublic
Actions

Authored by cy on Jun 12 2025, 2:55 PM.

Details

Reviewers

Commits

rG8f18d513c03a: gssd: Add support for MIT KRB5

Summary

Fix gssd build when building with MIT KRB5.

krb5_get_init_creds_opt_set_default_flags() is not an MIT KRB5 function.
It is also not needed to resolve the default keytable.

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

cy requested review of this revision.Jun 12 2025, 2:55 PM

cy created this revision.

rmacklem added inline comments.

usr.sbin/gssd/gssd.c
1196	Very minor nit (which means don't do it unless you agree). Maybe use HEIMDAL or a comment that indicates this is a HEIMDAL call instead of "not MIT"?

This revision is now accepted and ready to land.Jun 15 2025, 3:09 PM

cy added inline comments.Jun 16 2025, 2:44 AM

usr.sbin/gssd/gssd.c
1196	Good idea. I will add a comment, as I use the define MK_MITKRB5 elsewhere. That keeps every source #ifdef in the tree consistent. I've added the comment for the other files with this same #ifdef, pam_krb5 and pam_ksu.