Page MenuHomeFreeBSD
Differential D50797

pf: use counter_rate() for rate checking
ClosedPublic
Actions

Authored by kp on Jun 11 2025, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 2:53 AM
Unknown Object (File)
Sun, Sep 6, 7:55 PM
Unknown Object (File)
Sun, Sep 6, 4:13 PM
Unknown Object (File)
Sun, Sep 6, 4:00 PM
Unknown Object (File)
Sun, Sep 6, 2:53 PM
Unknown Object (File)
Fri, Sep 4, 5:20 PM
Unknown Object (File)
Thu, Sep 3, 10:21 PM
Unknown Object (File)
Thu, Sep 3, 4:38 PM
View All Files
Subscribers
ae
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
None
Group Reviewers
pfsense
Commits
rG53a341d0e445: pf: use counter_rate() for rate checking
Summary

This has the advantage of not requiring a lock. The current src node code runs
the rate check under a lock, so this won't immediately improve performance.
This prepares the way for future work, introducing packet rate matching on
rules, where the lack of lock will be important.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64765
Build 61649: arc lint + arc unit

Event Timeline

kp created this revision.Jun 11 2025, 7:40 PM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 3 others. · View Herald TranscriptJun 11 2025, 7:40 PM
Harbormaster completed remote builds in B64765: Diff 156837.Jun 11 2025, 7:40 PM
kp requested review of this revision.Jun 11 2025, 7:40 PM
kp added a parent revision: D50796: counter(9): rate limit periods may be more than 1 second.
kp added a child revision: D50798: pf: add a generic packet rate matching filter.
This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2025, 5:57 PM
Closed by commit rG53a341d0e445: pf: use counter_rate() for rate checking (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG53a341d0e445: pf: use counter_rate() for rate checking.

Revision Contents
Changeset List

PathSize
sys/
net/
10 lines
netpfil/
pf/
42 lines
15 lines
15 lines

Diff 156837

View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_ioctl.c

Loading...
View Options

sys/netpfil/pf/pf_nl.c

Loading...