Page MenuHomeFreeBSD

build: stop providing an explicit -fno-common
AcceptedPublic

Authored by kevans on Jun 7 2025, 3:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 26, 6:16 AM
Unknown Object (File)
Sun, Aug 10, 3:00 AM
Unknown Object (File)
Thu, Aug 7, 7:34 PM
Unknown Object (File)
Aug 1 2025, 6:22 PM
Unknown Object (File)
Jul 31 2025, 9:41 PM
Unknown Object (File)
Jul 24 2025, 7:40 AM
Unknown Object (File)
Jul 24 2025, 5:19 AM
Unknown Object (File)
Jul 22 2025, 5:24 PM
Subscribers

Details

Summary

All of the compilers used to build FreeBSD should now default to
-fno-common, so this isn't really necessary anymore -- it was only
added to avoid regressing the -fno-common build before it became the
default everywhere.

For <kmod.mk>, we'll leave that one in place. I didn't actually add
that one, and it's more important that we always have -fno-common in
kmod builds.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64699
Build 61583: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Jun 7 2025, 3:28 AM
This revision is now accepted and ready to land.Jun 7 2025, 3:29 AM

Unless I've missed a back out, the LLVM commit appears to have been included in LLVM 11 which is older than we care about https://github.com/llvm/llvm-project/commit/0a9fc9233e172601e26381810d093e02ef410f65