kern: unix: raise POLLIN when the remote end has shutdown writes
ClosedPublic
Actions

Authored by kevans on Fri, May 30, 1:59 AM.

Details

Reviewers

glebius
kib
adrian

Group Reviewers

network

Commits

rG6b90209aaf80: tests: ensure that unix/stream raises POLLIN after a shutdown(2)

Summary

Historically, select(2) and poll(2) will return POLLIN if the next
read(2) would return EOF to signal that the application should try.

Fix the new stream/seqpacket poll implementation to do the same to avoid
breaking applications that expect it, and select(2) which won't poll
for POLLRDHUP. select(2) arguably should poll for POLLRDHUP on the
read set as well, but poll(2) should also surface it with only
events=POLLIN.

Fixes: d15792780760e ("unix: new implementation of unix/stream [...]")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64540
Build 61424: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, May 30, 1:59 AM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, May 30, 1:59 AM

kevans requested review of this revision.Fri, May 30, 1:59 AM

Harbormaster completed remote builds in B64540: Diff 156284.Fri, May 30, 1:59 AM

kib accepted this revision.Fri, May 30, 2:42 AM

This revision is now accepted and ready to land.Fri, May 30, 2:42 AM

adrian accepted this revision.Fri, May 30, 2:44 AM

kevans added inline comments.Fri, May 30, 2:47 AM

sys/kern/uipc_usrreq.c
1695	Looking at uipc_socket.c's sopoll_generic, I wonder if this should instead be this to be technically correct (not that I can find anything actually using POLLIGNEOF except for the implicit use in pipe stuff?)