Page MenuHomeFreeBSD
Differential D50480

share/mk: improve CFLAGS description
Needs ReviewPublic
Actions

Authored by brooks on Thu, May 22, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 1:30 PM
Unknown Object (File)
Sat, May 24, 2:32 AM
Unknown Object (File)
Fri, May 23, 11:22 PM
Unknown Object (File)
Fri, May 23, 12:27 PM
Subscribers
bdrewery
imp

Details

Reviewers
emaste
jhb
Summary

Also document CXXFLAGS.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 64397
Build 61281: arc lint + arc unit

Event Timeline

brooks created this revision.Thu, May 22, 10:34 PM
Herald added subscribers: imp, bdrewery. · View Herald TranscriptThu, May 22, 10:34 PM
brooks requested review of this revision.Thu, May 22, 10:34 PM
Harbormaster completed remote builds in B64371: Diff 155899.Thu, May 22, 10:34 PM
brooks added a parent revision: D50479: share/mk: make *ADD and *FLAGS descriptions common.Thu, May 22, 10:34 PM
brooks added a child revision: D50481: share/mk/bsd.README: refer to the linker, not the loader.
emaste added inline comments.Thu, May 22, 11:26 PM
share/mk/bsd.README
136–139

Should we (in an ideal world, absent legacy and backwards compatibility considerations) really have CPPFLAGS and reserve CFLAGS specifically for C?

brooks added inline comments.Thu, May 22, 11:40 PM
share/mk/bsd.README
136–139

Certainly something C specific would be good, but we also need something to pass all the common flags. We've got a lot of ABI stuff in CFLAGS via bsd.cpu.mk. Likewise we add -target and --sysroot to XCFLAGS so they end up in CFLAGS.

jhb added inline comments.Fri, May 23, 5:34 PM
share/mk/bsd.README
136–139

Maybe either "things that are run though the C preprocessor" or "Flags to the compiler when compiling most things processed by the C preprocessor."?

152–153

This seems more consistent with the wording used for AFLAGS and CFLAGS?

brooks updated this revision to Diff 155950.Fri, May 23, 10:59 PM
  • Rephrased with some help from @jhb
Harbormaster completed remote builds in B64396: Diff 155950.Fri, May 23, 10:59 PM
brooks updated this revision to Diff 155951.Fri, May 23, 11:01 PM

Spell version correctly

Harbormaster completed remote builds in B64397: Diff 155951.Fri, May 23, 11:01 PM
brooks marked 3 inline comments as done.Fri, May 23, 11:11 PM

Revision Contents
Changeset List

PathSize
share/
mk/
8 lines

Diff 155951

View Options

share/mk/bsd.README

Loading...