Add udp6_connect and udp6_bind for ng_ksocket
Details
Details
- Reviewers
des glebius - Group Reviewers
network tests - Commits
- rGd86c5811cdb3: ng_ksocket: Add tests for IPv6
kyua test -k /usr/tests/Kyuafile sys/netgraph/ksocket
sys/netgraph/ksocket:udp6_bind -> passed [0.002s]
sys/netgraph/ksocket:udp6_connect -> passed [0.002s]
sys/netgraph/ksocket:udp_bind -> passed [0.002s]
sys/netgraph/ksocket:udp_connect -> passed [0.002s]
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 64236 Build 61120: arc lint + arc unit
Event Timeline
Comment Actions
This is my first experience with ATF and kyua. I would appreciate any guidance or suggestions you might have.
Comment Actions
the submitter asked me to land this. the changes look basically fine and match the existing IPv4 tests (and the new tests pass), but i don't know enough about netgraph to review this properly.
| tests/sys/netgraph/ksocket.c | ||
|---|---|---|
| 122 | per style(9), variable definitions should be at the start of the function, although since the rest of the file already violates this guideline it might make more sense to match the existing code. | |
| tests/sys/netgraph/ksocket.c | ||
|---|---|---|
| 122 | I could rewrite it based on style(9), if you think it's more appropriate. | |
| tests/sys/netgraph/ksocket.c | ||
|---|---|---|
| 122 | Please move the definition (and initialization) of mkp to right below that of sa in all test cases, the rest is fine. | |
| tests/sys/netgraph/ksocket.c | ||
|---|---|---|
| 122 | Order of use applied for connect functions by moving mkp to right below of sa and also moving mkp of bind functions right above of sin. | |
This comment was removed by p.mousavizadeh_protonmail.com.
Comment Actions
@p.mousavizadeh_protonmail.com i intend to land this for you but it needs a review from at least des or kevans first which might not happen until next week, i'll try to keep up but if you think it's stalled feel free to ping me.
Comment Actions
ping @ivy
it seems like the review process has stalled. I appreciate your help in getting this moving again.
Thank you!