ng_sample: improve styling
ClosedPublic
Actions

Authored by p.mousavizadeh_protonmail.com on Wed, May 14, 10:08 AM.

Details

Reviewers

ivy
kp
des

Group Reviewers

network

Commits

rG9f290050a6cd: ng_sample: fix style nits
rG49d9f344f67e: ng_sample: fix style nits
rG95c414dd27c2: ng_sample: fix style nits

Summary

Most of the developers used the (resp == NULL) style in their code. New developers will try to follow the ng_sample and may use the (!resp) style which is not consistent with other netgraph modules, also not recommended by MISRA-C.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

p.mousavizadeh_protonmail.com created this revision.Wed, May 14, 10:08 AM

Herald added subscribers: melifaro, donner, imp. · View Herald TranscriptWed, May 14, 10:08 AM

p.mousavizadeh_protonmail.com requested review of this revision.Wed, May 14, 10:08 AM

Harbormaster completed remote builds in B64158: Diff 155429.Wed, May 14, 10:08 AM

ivy accepted this revision.Wed, May 14, 2:45 PM

ivy added a subscriber: ivy.

ivy added inline comments.

sys/netgraph/ng_sample.c
323	while you're here, i believe this extra space is a typo that could be removed.

This revision is now accepted and ready to land.Wed, May 14, 2:45 PM

We don't follow MISRA-C, but style(9) does also require this, so the change should be made anyway.

ng_sample: apply style(9)

This revision now requires review to proceed.Thu, May 15, 2:18 PM

Harbormaster completed remote builds in B64200: Diff 155513.Thu, May 15, 2:18 PM

Done

p.mousavizadeh_protonmail.com removed a reviewer: glebius.Thu, May 15, 2:19 PM

Herald added a subscriber: glebius. · View Herald TranscriptThu, May 15, 2:19 PM

@ivy why don't you land this

This revision is now accepted and ready to land.Fri, May 16, 12:26 PM

p.mousavizadeh_protonmail.com retitled this revision from ng_sample: As defined in MISRA-C, use resp == NULL to ng_sample: ng_sample: improve styling.Fri, May 16, 8:11 PM

p.mousavizadeh_protonmail.com retitled this revision from ng_sample: ng_sample: improve styling to ng_sample: improve styling.Fri, May 16, 8:18 PM

Closed by commit rG95c414dd27c2: ng_sample: fix style nits (authored by p.mousavizadeh_protonmail.com, committed by ivy). · Explain WhyFri, May 16, 8:33 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG95c414dd27c2: ng_sample: fix style nits.

zarychtam_plan-b.pwste.edu.pl mentioned this in D50108: ip6: implement RFC 8981-advised temporary IID generation.Fri, May 16, 11:02 PM

ivy added a commit: rG49d9f344f67e: ng_sample: fix style nits.Mon, May 19, 9:31 AM

ivy added a commit: rG9f290050a6cd: ng_sample: fix style nits.Wed, May 21, 12:30 AM