Differential D50309

subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr
ClosedPublic
Actions

Authored by andrew on May 12 2025, 1:05 PM.

Tags

None

Referenced Files

	F170701771: D50309.id155375.diff
	Sun, Sep 6, 2:41 AM

	Unknown Object (File)
	Sun, Sep 6, 12:54 AM

	Unknown Object (File)
	Sun, Sep 6, 12:24 AM

	Unknown Object (File)
	Sat, Sep 5, 1:49 PM

	Unknown Object (File)
	Sat, Sep 5, 10:59 AM

	Unknown Object (File)
	Sat, Sep 5, 6:09 AM

	Unknown Object (File)
	Fri, Sep 4, 9:23 AM

	Unknown Object (File)
	Fri, Sep 4, 6:36 AM

Subscribers

Details

Reviewers

mhorne
mmel

Group Reviewers

ARM
arm64
riscv

Commits

rGebeeeae67845: subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr

Summary

We can now support pmap_mapdev_attr on arm. Switch to use this to
implement pmap_mapdev to reduce duplicate code.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.May 12 2025, 1:05 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMay 12 2025, 1:05 PM

andrew requested review of this revision.May 12 2025, 1:05 PM

andrew added a parent revision: D50308: subr_devmap: Add the function name to KASSERT.

Harbormaster completed remote builds in B64102: Diff 155328.May 12 2025, 1:05 PM

mhorne accepted this revision.May 12 2025, 4:03 PM

This revision is now accepted and ready to land.May 12 2025, 4:03 PM

mmel mentioned this in D50307: arm: Make the pmap_kenter signature like arm64.May 12 2025, 8:14 PM

Only call devmap_ptov for device mappings

This revision now requires review to proceed.May 13 2025, 10:29 AM

Harbormaster completed remote builds in B64126: Diff 155375.May 13 2025, 10:29 AM

mmel added a subscriber: mmel.May 14 2025, 11:52 AM

mmel added inline comments.

sys/kern/subr_devmap.c
266	I'm afraid that multiple mappings of the same page with different cache or type properties leads to undefined behavior on most (if not all) architectures. In this case, I don't see a solution other than panic().

KASSERT ma == VM_MEMATTR_DEVICE

Harbormaster completed remote builds in B64170: Diff 155443.May 14 2025, 12:57 PM

Thanks

This revision is now accepted and ready to land.May 14 2025, 6:26 PM

Closed by commit rGebeeeae67845: subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr (authored by andrew). · Explain WhyMay 15 2025, 3:28 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGebeeeae67845: subr_devmap: Implement pmap_mapdev with pmap_mapdev_attr.

Revision Contents
Changeset List

Path

Size

sys/

arm/

include/

8 lines

kern/

51 lines

Diff 155521

sys/arm/include/pmap.h

Loading...

sys/kern/subr_devmap.c

Loading...