Page MenuHomeFreeBSD
Differential D50252

loader: i386: use -z nostart-stop-gc for bfd as well
ClosedPublic
Actions

Authored by kevans on Thu, May 8, 4:20 AM.
Tags
None
Referenced Files
F117595366: D50252.id155162.diff
Tue, May 20, 2:43 PM
Unknown Object (File)
Sat, May 17, 12:59 AM
Unknown Object (File)
Thu, May 15, 7:26 PM
Unknown Object (File)
Thu, May 15, 4:34 PM
Unknown Object (File)
Thu, May 15, 12:42 PM
Unknown Object (File)
Thu, May 15, 11:53 AM
Unknown Object (File)
Wed, May 14, 11:57 PM
Unknown Object (File)
Sun, May 11, 7:47 AM
View All 12 Files
Subscribers
dab
emaste
jrtc27
sjg

Details

Reviewers
adrian
dim
imp
manu
sjg
Commits
rG78661696e639: loader: i386: use -z nostart-stop-gc for bfd as well
Summary

binutils 2.37 seems to have added the knob, so let's just use that
version here (it's not clear if GC'ing start/stop symbols was actually
made the default at the time, and it didn't seem worth it to dig much
further). This fixes misbehavior when built with more recent binutils,
as we do rely on linker sets for loader commands that we use.

Reported by: sjg

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Thu, May 8, 4:20 AM
Herald added a reviewer: manu. · View Herald TranscriptThu, May 8, 4:20 AM
Herald added a subscriber: dab. · View Herald Transcript
kevans requested review of this revision.Thu, May 8, 4:20 AM
Harbormaster completed remote builds in B64006: Diff 155125.Thu, May 8, 4:20 AM
sjg accepted this revision.Thu, May 8, 4:31 AM
sjg added a subscriber: sjg.

Looks good

This revision is now accepted and ready to land.Thu, May 8, 4:31 AM
dim accepted this revision.Thu, May 8, 6:55 AM

Sure.

Closed by commit rG78661696e639: loader: i386: use -z nostart-stop-gc for bfd as well (authored by kevans). · Explain WhyThu, May 8, 7:47 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG78661696e639: loader: i386: use -z nostart-stop-gc for bfd as well.
emaste added a subscriber: emaste.Thu, May 8, 8:27 PM
emaste added inline comments.
stand/i386/loader/Makefile
95

and bfd ld 2.37 and higher

jrtc27 added a subscriber: jrtc27.Thu, May 8, 10:49 PM

Hm, binutils should still be defaulting to -znostart-stop-gc even today in their master branch. So this really should be a no-op, this shouldn't be the cause of any issues. (Unless sjg is building with some modified environment that overrides that default, I suppose, but that's shooting oneself in the foot...)

Revision Contents
Changeset List

PathSize
stand/
i386/
loader/
3 lines

Diff 155162

View Options

stand/i386/loader/Makefile

Loading...