pf: factor out duplicate code to undo nat
ClosedPublic
Actions

Authored by kp on Mar 30 2025, 7:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 1, 9:16 PM

	Unknown Object (File)
	Tue, Mar 31, 4:57 AM

	Unknown Object (File)
	Thu, Mar 26, 2:55 AM

	Unknown Object (File)
	Sun, Mar 22, 8:17 PM

	Unknown Object (File)
	Fri, Mar 13, 5:58 PM

	Unknown Object (File)
	Wed, Mar 11, 7:36 PM

	Unknown Object (File)
	Mar 3 2026, 8:24 PM

	Unknown Object (File)
	Mar 2 2026, 6:21 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

glebius
markj

Group Reviewers

network

Commits

rG1bf46184cdc3: pf: factor out duplicate code to undo nat

Summary

Suggested by: markj
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63216
Build 60100: arc lint + arc unit

Event Timeline

kp created this revision.Mar 30 2025, 7:55 PM

Herald added subscribers: vegeta_tuxpowered.net, melifaro, farrokhi and 2 others. · View Herald TranscriptMar 30 2025, 7:55 PM

kp requested review of this revision.Mar 30 2025, 7:55 PM

Harbormaster completed remote builds in B63216: Diff 152879.Mar 30 2025, 7:55 PM

kp added a parent revision: D49581: pf: inline pf_addrcpy().Mar 30 2025, 7:55 PM

glebius added inline comments.Mar 30 2025, 11:27 PM

sys/net/pfvar.h
601	This looks like a part of D49581.

markj accepted this revision as: markj.Mar 31 2025, 12:33 AM

This revision is now accepted and ready to land.Mar 31 2025, 12:33 AM

kp added inline comments.Mar 31 2025, 9:49 AM

sys/net/pfvar.h
601	You're right. I think I messed up a squash.

Closed by commit rG1bf46184cdc3: pf: factor out duplicate code to undo nat (authored by kp). · Explain WhyMar 31 2025, 2:58 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG1bf46184cdc3: pf: factor out duplicate code to undo nat.

Revision Contents
Changeset List

Path

Size

sys/

net/

pfvar.h

2 lines

netpfil/

pf/

pf.c

33 lines

Diff 152879

View Options

sys/net/pfvar.h