pf: explicitly NULL state key pointers
ClosedPublic
Actions

Authored by kp on Mar 28 2025, 2:48 PM.

Details

Reviewers

glebius
markj

Group Reviewers

network

Commits

rGb89bc49a6348: pf: explicitly NULL state key pointers
rG4df4b69530c3: pf: explicitly NULL state key pointers
rG592418343348: pf: explicitly NULL state key pointers

Summary

After the pf_state_insert() call we may not use these pointers again.
Explicitly NULL them to ensure we don't.
Also NULL them out if we free the keys directly.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63177
Build 60061: arc lint + arc unit

Event Timeline

kp created this revision.Mar 28 2025, 2:48 PM

Herald added subscribers: vegeta_tuxpowered.net, melifaro, farrokhi, imp. · View Herald TranscriptMar 28 2025, 2:48 PM

kp requested review of this revision.Mar 28 2025, 2:48 PM

Harbormaster completed remote builds in B63177: Diff 152792.Mar 28 2025, 2:48 PM

kp added a parent revision: D49552: pf: simplify action resolution in pf_test_rule().Mar 28 2025, 2:48 PM

glebius accepted this revision as: glebius.Mar 28 2025, 8:09 PM

This revision is now accepted and ready to land.Mar 28 2025, 8:09 PM

markj accepted this revision as: markj.Mar 29 2025, 8:20 AM

Closed by commit rG592418343348: pf: explicitly NULL state key pointers (authored by kp). · Explain WhyMar 31 2025, 2:58 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG592418343348: pf: explicitly NULL state key pointers.

kp added a commit: rG4df4b69530c3: pf: explicitly NULL state key pointers.Apr 21 2025, 9:16 PM

kp added a commit: rGb89bc49a6348: pf: explicitly NULL state key pointers.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

4 lines

Diff 152792

View Options

pf: explicitly NULL state key pointersClosedPublicActions