pf: simplify action resolution in pf_test_rule()
ClosedPublic
Actions

Authored by kp on Mar 28 2025, 2:47 PM.

Details

Reviewers

glebius
markj

Group Reviewers

network

Commits

rGd7eacb1531e7: pf: simplify action resolution in pf_test_rule()

Summary

Rather than looking at state keys after the fact just save the action in the
nat64 section. This simplifies things and it also ensures we don't use state
keys after pf_insert_state().

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Mar 28 2025, 2:47 PM

Herald added subscribers: vegeta_tuxpowered.net, melifaro, farrokhi, imp. · View Herald TranscriptMar 28 2025, 2:47 PM

kp requested review of this revision.Mar 28 2025, 2:47 PM

Harbormaster completed remote builds in B63176: Diff 152791.Mar 28 2025, 2:47 PM

kp added a parent revision: D49551: pf: don't use state keys after pf_state_insert().Mar 28 2025, 2:47 PM

kp added a child revision: D49553: pf: explicitly NULL state key pointers.

glebius accepted this revision as: glebius.Mar 28 2025, 8:08 PM

This revision is now accepted and ready to land.Mar 28 2025, 8:08 PM

markj accepted this revision as: markj.Mar 29 2025, 8:20 AM

Closed by commit rGd7eacb1531e7: pf: simplify action resolution in pf_test_rule() (authored by kp). · Explain WhyMar 31 2025, 2:58 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGd7eacb1531e7: pf: simplify action resolution in pf_test_rule().

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

10 lines

Diff 152906

View Options

pf: simplify action resolution in pf_test_rule()ClosedPublicActions