Page MenuHomeFreeBSD
Differential D49289

libsa: smbios: Allow to run smbios_probe() multiple times
ClosedPublic
Actions

Authored by olce on Mar 7 2025, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 2:54 PM
Unknown Object (File)
Thu, May 21, 10:58 PM
Unknown Object (File)
May 12 2026, 12:44 PM
Unknown Object (File)
May 9 2026, 10:05 AM
Unknown Object (File)
Apr 21 2026, 6:15 AM
Unknown Object (File)
Apr 17 2026, 9:46 PM
Unknown Object (File)
Apr 17 2026, 8:01 PM
Unknown Object (File)
Apr 16 2026, 12:19 PM
View All 67 Files
Subscribers
dab

Details

Reviewers
emaste
imp
markj
manu
Commits
rG9b8e1558c961: libsa: smbios: Allow to run smbios_probe() multiple times
rGc340797e08d8: libsa: smbios: Allow to run smbios_probe() multiple times
Summary

This is in preparation for modifying the EFI loader to favor a v3 table
if present.

As an impact, caller smbios_match() has been changed so that it only
calls smbios_probe() with NULL (non-EFI discovery) once.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Mar 7 2025, 4:57 PM
Herald added a reviewer: manu. · View Herald TranscriptMar 7 2025, 4:57 PM
Herald added a subscriber: dab. · View Herald Transcript
olce requested review of this revision.Mar 7 2025, 4:57 PM
Harbormaster completed remote builds in B62829: Diff 152025.Mar 7 2025, 4:57 PM
olce added a parent revision: D49288: libsa: smbios: Use 64-bit entry point if table below 4GB on non-EFI boot.Mar 7 2025, 4:59 PM
olce added a child revision: D49290: libsa: smbios_detect(): Return the entry point address.
imp accepted this revision.Mar 7 2025, 5:52 PM

This is good, though I'm thinking the XXX comment should maybe be expanded a word or five and the XXX removed. Up to you though.

This revision is now accepted and ready to land.Mar 7 2025, 5:52 PM
markj accepted this revision.Mar 9 2025, 9:24 AM
olce added a comment.Mar 11 2025, 11:01 AM
In D49289#1123977, @imp wrote:

This is good, though I'm thinking the XXX comment should maybe be expanded a word or five and the XXX removed. Up to you though.

Done in the final commit.

Closed by commit rGc340797e08d8: libsa: smbios: Allow to run smbios_probe() multiple times (authored by olce). · Explain WhyMar 11 2025, 2:05 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGc340797e08d8: libsa: smbios: Allow to run smbios_probe() multiple times.
olce added a commit: rG9b8e1558c961: libsa: smbios: Allow to run smbios_probe() multiple times.Apr 8 2025, 1:41 PM

Revision Contents
Changeset List

PathSize
stand/
libsa/
22 lines

Diff 152142

View Options

stand/libsa/smbios.c

Loading...