Page MenuHomeFreeBSD

libsa: smbios: probe: BCD revision parsing is v2-only code; Expand comments
ClosedPublic

Authored by olce on Mar 7 2025, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 5:23 AM
Unknown Object (File)
Mon, Oct 13, 5:57 PM
Unknown Object (File)
Sun, Oct 12, 3:08 AM
Unknown Object (File)
Thu, Oct 9, 2:06 AM
Unknown Object (File)
Mon, Oct 6, 9:20 AM
Unknown Object (File)
Mon, Oct 6, 7:06 AM
Unknown Object (File)
Sun, Sep 21, 8:49 PM
Unknown Object (File)
Sun, Sep 21, 4:06 AM
Subscribers

Details

Summary

The code parsing the BCD revision is only meaningful on v2, so move it
away into the appropriate 'if' branch to ease reading (and to avoid
a useless test).

Expand comments. In particular, make it clear that setting
'smbios.count' to '-1' removes the limit of the number of structures to
parse.

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Mar 7 2025, 4:57 PM
This revision is now accepted and ready to land.Mar 7 2025, 5:04 PM
markj added inline comments.
stand/libsa/smbios.c
586

"No." is a somewhat common abbreviation for "number". "Nb" looks like a typo to me. If you're going to change it, I'd rather use "No." or just "Number".