Page MenuHomeFreeBSD

libsa: smbios: probe: BCD revision parsing is v2-only code; Expand comments
AcceptedPublic

Authored by olce on Fri, Mar 7, 4:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 8:19 AM
Unknown Object (File)
Sat, Mar 8, 5:44 AM
Unknown Object (File)
Sat, Mar 8, 4:28 AM
Subscribers

Details

Summary

The code parsing the BCD revision is only meaningful on v2, so move it
away into the appropriate 'if' branch to ease reading (and to avoid
a useless test).

Expand comments. In particular, make it clear that setting
'smbios.count' to '-1' removes the limit of the number of structures to
parse.

No functional change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62824
Build 59708: arc lint + arc unit

Event Timeline

olce requested review of this revision.Fri, Mar 7, 4:57 PM
This revision is now accepted and ready to land.Fri, Mar 7, 5:04 PM
markj added inline comments.
stand/libsa/smbios.c
586

"No." is a somewhat common abbreviation for "number". "Nb" looks like a typo to me. If you're going to change it, I'd rather use "No." or just "Number".