Differential D49280

libsa: smbios: style(9): Entry point parsing comments
ClosedPublic
Actions

Authored by olce on Mar 7 2025, 4:57 PM.

Tags

None

Referenced Files

	F151163428: D49280.id152133.diff
	Mon, Apr 6, 12:59 PM

	Unknown Object (File)
	Sat, Mar 28, 11:49 AM

	Unknown Object (File)
	Sun, Mar 22, 7:14 PM

	Unknown Object (File)
	Sun, Mar 22, 2:10 AM

	Unknown Object (File)
	Wed, Mar 18, 5:47 AM

	Unknown Object (File)
	Tue, Mar 17, 5:43 PM

	Unknown Object (File)
	Feb 25 2026, 9:23 AM

	Unknown Object (File)
	Feb 24 2026, 3:54 PM

View All 61 Files

Subscribers

Details

Reviewers

emaste
imp
markj
manu

Commits

rG4af7f393ec9a: libsa: smbios: style(9): Entry point parsing comments
rGa609592ddcdf: libsa: smbios: style(9): Entry point parsing comments

Summary

Move the comments so that lines stay of reasonable length.

Remove comments that state the obvious.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

olce created this revision.Mar 7 2025, 4:57 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 7 2025, 4:57 PM

Herald added a subscriber: dab. · View Herald Transcript

olce requested review of this revision.Mar 7 2025, 4:57 PM

Harbormaster completed remote builds in B62820: Diff 152016.Mar 7 2025, 4:57 PM

olce added a parent revision: D49279: libsa: smbios: style(9): SMBIOS_GET8(): Split overlong line.Mar 7 2025, 4:59 PM

olce added a child revision: D49281: libsa: smbios: Rename 64-bit entry point's guards.

markj accepted this revision.Mar 9 2025, 8:37 AM

This revision is now accepted and ready to land.Mar 9 2025, 8:37 AM

Closed by commit rGa609592ddcdf: libsa: smbios: style(9): Entry point parsing comments (authored by olce). · Explain WhyMar 11 2025, 2:05 PM

This revision was automatically updated to reflect the committed changes.

olce added a commit: rGa609592ddcdf: libsa: smbios: style(9): Entry point parsing comments.

olce added a commit: rG4af7f393ec9a: libsa: smbios: style(9): Entry point parsing comments.Apr 8 2025, 1:41 PM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

28 lines

Diff 152133

stand/libsa/smbios.c

Loading...