Page MenuHomeFreeBSD

libsa: smbios: Allow to run smbios_probe() multiple times
ClosedPublic

Authored by olce on Mar 7 2025, 4:57 PM.
Tags
None
Referenced Files
F166166556: D49289.id.diff
Wed, Aug 12, 1:00 AM
F166164868: D49289.id152142.diff
Wed, Aug 12, 12:43 AM
Unknown Object (File)
Tue, Aug 11, 11:45 AM
Unknown Object (File)
Tue, Aug 11, 12:13 AM
Unknown Object (File)
Mon, Aug 10, 12:54 PM
Unknown Object (File)
Mon, Aug 10, 11:22 AM
Unknown Object (File)
Mon, Aug 10, 10:43 AM
Unknown Object (File)
Mon, Aug 10, 10:20 AM
Subscribers

Details

Summary

This is in preparation for modifying the EFI loader to favor a v3 table
if present.

As an impact, caller smbios_match() has been changed so that it only
calls smbios_probe() with NULL (non-EFI discovery) once.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Mar 7 2025, 4:57 PM

This is good, though I'm thinking the XXX comment should maybe be expanded a word or five and the XXX removed. Up to you though.

This revision is now accepted and ready to land.Mar 7 2025, 5:52 PM
In D49289#1123977, @imp wrote:

This is good, though I'm thinking the XXX comment should maybe be expanded a word or five and the XXX removed. Up to you though.

Done in the final commit.