Page MenuHomeFreeBSD
Differential D49155

arm64/vmm: Don't load on Ampere eMAG
ClosedPublic
Actions

Authored by andrew on Feb 27 2025, 9:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 28, 5:58 PM
Unknown Object (File)
Wed, Aug 27, 12:24 AM
Unknown Object (File)
Tue, Aug 26, 2:51 PM
Unknown Object (File)
Fri, Aug 22, 4:50 AM
Unknown Object (File)
Tue, Aug 19, 7:44 PM
Unknown Object (File)
Mon, Aug 18, 2:28 AM
Unknown Object (File)
Sun, Aug 17, 5:17 AM
Unknown Object (File)
Thu, Aug 14, 3:39 PM
View All 61 Files
Subscribers
bz
emaste
imp

Details

Reviewers
dch
tuexen
manu
Group Reviewers
arm64
Commits
rG872fc1b8de1a: arm64/vmm: Don't load on Ampere eMAG
Summary

Loading vmm.ko on Ampere eMAG locks up the system. Block loading for
now until it can be fixed.

PR: 285051
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62662
Build 59546: arc lint + arc unit

Event Timeline

andrew created this revision.Feb 27 2025, 9:52 AM
Herald added a reviewer: manu. · View Herald TranscriptFeb 27 2025, 9:52 AM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Feb 27 2025, 9:52 AM
Harbormaster completed remote builds in B62661: Diff 151567.Feb 27 2025, 9:52 AM
tuexen accepted this revision.Feb 27 2025, 10:37 AM

Is there anything I could do to help fixing the root cause?

This revision is now accepted and ready to land.Feb 27 2025, 10:37 AM
tuexen added a comment.Feb 27 2025, 10:48 AM

After approving:
I applied the patch, compiled and installed the kernel, rebooted and tried sudo kldload vmm.
The system became unresponsive. Is a buildworld needed? I thought just building kernel
includes building the kernel modules including vmm.ko...
Any idea why the above fix did not work?

andrew updated this revision to Diff 151568.Feb 27 2025, 10:54 AM

Use the correct CPU Implementer ID

This revision now requires review to proceed.Feb 27 2025, 10:54 AM
Harbormaster completed remote builds in B62662: Diff 151568.Feb 27 2025, 10:54 AM
tuexen added a comment.Feb 27 2025, 12:21 PM

Tested again:
sudo kldload vmm
does NOT lock up the system anymore.
/var/log/messages
contains
vgic0: <Virtual GIC v3> on gic0
module_register_init: MOD_LOAD (vmm, 0xffff0002a5298574, 0) error 6
vgic0: detached
as expected.
What is unexpected for me is that after sudo kldload vmm,
kldstat reports vmm.ko as being loaded.
sudo kldunload vmm
succeeds. Is it expected, that vmm.ko is reported as loaded even though loading
of it fails?

andrew added a comment.Feb 27 2025, 1:55 PM

From a quick look at kldload handling in the kernel it appears that is the expected behaviour.

tuexen accepted this revision.Feb 27 2025, 3:03 PM
In D49155#1121141, @andrew wrote:

From a quick look at kldload handling in the kernel it appears that is the expected behaviour.

OK.

This revision is now accepted and ready to land.Feb 27 2025, 3:03 PM
bz added a subscriber: bz.Feb 27 2025, 8:31 PM
bz added inline comments.
sys/arm64/vmm/vmm.c
317

I think the comment is misleading if it's a hard freeze for the machine.

Closed by commit rG872fc1b8de1a: arm64/vmm: Don't load on Ampere eMAG (authored by andrew). · Explain WhyMar 27 2025, 1:48 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG872fc1b8de1a: arm64/vmm: Don't load on Ampere eMAG.

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
17 lines

Diff 151568

View Options

sys/arm64/vmm/vmm.c

Show All 36 Lines
#include <sys/mutex.h> #include <sys/mutex.h>
#include <sys/pcpu.h> #include <sys/pcpu.h>
#include <sys/proc.h> #include <sys/proc.h>
#include <sys/socket.h> #include <sys/socket.h>
#include <sys/socketvar.h> #include <sys/socketvar.h>
#include <sys/time.h> #include <sys/time.h>
#include <sys/uio.h> #include <sys/uio.h>
#include <netinet/tcp.h>
#include <rpc/rpc.h> #include <rpc/rpc.h>
#include <rpc/rpc_com.h> #include <rpc/rpc_com.h>
#include <rpc/krpc.h> #include <rpc/krpc.h>
#include <rpc/rpcsec_tls.h> #include <rpc/rpcsec_tls.h>
static enum clnt_stat clnt_reconnect_call(CLIENT *, struct rpc_callextra *, static enum clnt_stat clnt_reconnect_call(CLIENT *, struct rpc_callextra *,
rpcproc_t, struct mbuf *, struct mbuf **, struct timeval); rpcproc_t, struct mbuf *, struct mbuf **, struct timeval);
static void clnt_reconnect_geterr(CLIENT *, struct rpc_err *); static void clnt_reconnect_geterr(CLIENT *, struct rpc_err *);
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Linesclnt_reconnect_create(
rc->rc_retries = INT_MAX; rc->rc_retries = INT_MAX;
rc->rc_privport = FALSE; rc->rc_privport = FALSE;
rc->rc_waitchan = "rpcrecv"; rc->rc_waitchan = "rpcrecv";
rc->rc_intr = 0; rc->rc_intr = 0;
rc->rc_connecting = FALSE; rc->rc_connecting = FALSE;
rc->rc_closed = FALSE; rc->rc_closed = FALSE;
rc->rc_ucred = crdup(curthread->td_ucred); rc->rc_ucred = crdup(curthread->td_ucred);
rc->rc_client = NULL; rc->rc_client = NULL;
rc->rc_ddp = false;
rc->rc_tls = false; rc->rc_tls = false;
rc->rc_tlscertname = NULL; rc->rc_tlscertname = NULL;
rc->rc_reconcall = NULL; rc->rc_reconcall = NULL;
rc->rc_reconarg = NULL; rc->rc_reconarg = NULL;
cl->cl_refs = 1; cl->cl_refs = 1;
cl->cl_ops = &clnt_reconnect_ops; cl->cl_ops = &clnt_reconnect_ops;
cl->cl_private = (caddr_t)(void *)rc; cl->cl_private = (caddr_t)(void *)rc;
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines if (rc->rc_tls && newclient != NULL) {
rpc_createerr.cf_error.re_errno = 0; rpc_createerr.cf_error.re_errno = 0;
CLNT_CLOSE(newclient); CLNT_CLOSE(newclient);
CLNT_RELEASE(newclient); CLNT_RELEASE(newclient);
newclient = NULL; newclient = NULL;
td->td_ucred = oldcred; td->td_ucred = oldcred;
goto out; goto out;
} }
} }
if (rc->rc_ddp && newclient != NULL) {
int optval = 1;
(void)so_setsockopt(so, IPPROTO_TCP, TCP_USE_DDP,
&optval, sizeof(optval));
}
rmacklemUnsubmitted
Not Done
Inline Actions

Normally the clnt_rc.c (reconnect layer) would
do a CLSET_TCP_DDP and the so_setsockopt()
would be done for CLSET_TCP_DDP in clnt_vc.c
and ignored in clnt_dg.c.

I've never been much of an object oriented guy,
but the Sun folk loved these layers.

rmacklem: Normally the clnt_rc.c (reconnect layer) would do a CLSET_TCP_DDP and the so_setsockopt() would…
if (newclient != NULL && rc->rc_reconcall != NULL) if (newclient != NULL && rc->rc_reconcall != NULL)
(*rc->rc_reconcall)(newclient, rc->rc_reconarg, (*rc->rc_reconcall)(newclient, rc->rc_reconarg,
rc->rc_ucred); rc->rc_ucred);
} }
td->td_ucred = oldcred; td->td_ucred = oldcred;
if (!newclient) { if (!newclient) {
soclose(so); soclose(so);
▲ Show 20 Lines • Show All 292 Lines • ▼ Show 20 Lines case CLSET_TLSCERTNAME:
rc->rc_tlscertname = mem_alloc(slen); rc->rc_tlscertname = mem_alloc(slen);
strlcpy(rc->rc_tlscertname, info, slen); strlcpy(rc->rc_tlscertname, info, slen);
break; break;
case CLSET_RECONUPCALL: case CLSET_RECONUPCALL:
upcp = (struct rpc_reconupcall *)info; upcp = (struct rpc_reconupcall *)info;
rc->rc_reconcall = upcp->call; rc->rc_reconcall = upcp->call;
rc->rc_reconarg = upcp->arg; rc->rc_reconarg = upcp->arg;
break;
case CLSET_DDP:
rc->rc_ddp = true;
break; break;
default: default:
return (FALSE); return (FALSE);
} }
return (TRUE); return (TRUE);
} }
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines