vm_phys_early_alloc(): Align to PAGE_SIZE; Review callers' alignment
AcceptedPublic
Actions

Authored by olce on Jan 23 2025, 5:16 PM.

Details

Reviewers

markj
dougm
alc

Summary

Switch alignment of vm_phys_early_alloc() to PAGE_SIZE as it is the most
used one.

Review all calling points and change those where greater alignment is
really needed to use vm_phys_early_alloc_ex().

In particular, in PowerPC's moea64_page_array_startup(), reduce the
requested alignment to what the hardware actually requires
('moea64_large_page_size') instead of the size of the page array portion
for a full domain.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62305
Build 59189: arc lint + arc unit

Event Timeline

olce created this revision.Jan 23 2025, 5:16 PM

Herald added subscribers: jhibbits, imp. · View Herald TranscriptJan 23 2025, 5:16 PM

olce requested review of this revision.Jan 23 2025, 5:16 PM

Harbormaster completed remote builds in B61936: Diff 149793.Jan 23 2025, 5:16 PM

olce added a parent revision: D48636: vm_phys_early_alloc_ex*(): Switch allocation strategy to best fit.Jan 23 2025, 5:21 PM

olce added a child revision: D48638: vm_phys_early_alloc_ex*(): Introduce VM_PHYS_EAF_ADDR_BOUNDARIES_FIRST.

Explicitly mention the change in moea64_page_array_startup() in the commit message.

Impacts of vm_phys_early_alloc_ex()'s change of signature.

Fix a small typo "bug" in mmu_radix_page_array_startup() (a 0 instead of a -1
for the domain value; however, this code is under #ifdef notyet, so not
active).

Harbormaster completed remote builds in B62305: Diff 150702.Feb 7 2025, 6:52 PM

olce edited child revisions, added: D48894: vm_phys_early_alloc(): Remove the 'domain' argument; removed: D48638: vm_phys_early_alloc_ex*(): Introduce VM_PHYS_EAF_ADDR_BOUNDARIES_FIRST.Feb 7 2025, 8:02 PM

markj accepted this revision.Feb 18 2025, 9:05 PM

This revision is now accepted and ready to land.Feb 18 2025, 9:05 PM