ctld: Factor our code to setup a listening socket into a separate function
ClosedPublic
Actions

Authored by jhb on Jan 22 2025, 7:53 PM.

Details

Reviewers

trasz
asomers
mav

Commits

rG0cc467282f13: ctld: Factor out code to setup a listening socket into a separate function
rGb4a5ab97c810: ctld: Factor out code to setup a listening socket into a separate function

Summary

While here:

Reuse the address family from the addrinfo structure instead of calling getsockname(2) on the socket.

Remove a bogus comment about the PCP option.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61889
Build 58773: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 22 2025, 7:53 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 22 2025, 7:53 PM

jhb requested review of this revision.Jan 22 2025, 7:53 PM

jhb added a parent revision: D48595: ctld: Use nvlist instead of home-rolled name-value lists.

jhb added a child revision: D48597: ctld: Use kevent(2) for socket events rather than select(2).

Harbormaster completed remote builds in B61889: Diff 149720.Jan 22 2025, 7:53 PM

asomers accepted this revision.Jan 22 2025, 10:26 PM

This revision is now accepted and ready to land.Jan 22 2025, 10:26 PM

mav accepted this revision.Jan 23 2025, 4:48 PM

Closed by commit rGb4a5ab97c810: ctld: Factor out code to setup a listening socket into a separate function (authored by jhb). · Explain WhyJan 24 2025, 2:55 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb4a5ab97c810: ctld: Factor out code to setup a listening socket into a separate function.

jhb added a commit: rG0cc467282f13: ctld: Factor out code to setup a listening socket into a separate function.Jan 27 2026, 6:44 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ctld/

ctld.c

199 lines

Diff 149720

View Options

ctld: Factor our code to setup a listening socket into a separate functionClosedPublicActions