Use device_delete_children instead of explicit calls to device_delete_child
ClosedPublic
Actions

Authored by jhb on Dec 6 2024, 10:30 PM.

Details

Reviewers

imp
andrew
manu

Commits

rG28f5e880e8b2: Use device_delete_children instead of explicit calls to device_delete_child

Summary

This is simpler and more robust in the face of potential double-frees
(e.g. if called after bus_generic_detach which will delete devices in
a future commit).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60999
Build 57883: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 6 2024, 10:30 PM

Herald added a reviewer: andrew. · View Herald TranscriptDec 6 2024, 10:30 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: emaste. · View Herald Transcript

jhb requested review of this revision.Dec 6 2024, 10:30 PM

jhb added a parent revision: D47957: Use bus_detach_children instead of bus_generic_detach.

Harbormaster completed remote builds in B60999: Diff 147636.Dec 6 2024, 10:30 PM

jhb added a child revision: D47959: bus_generic_detach: Delete children after detaching them.Dec 6 2024, 10:30 PM

manu accepted this revision.Dec 7 2024, 11:57 AM

This revision is now accepted and ready to land.Dec 7 2024, 11:57 AM

imp accepted this revision.Dec 8 2024, 5:32 PM

Closed by commit rG28f5e880e8b2: Use device_delete_children instead of explicit calls to device_delete_child (authored by jhb). · Explain WhyJan 2 2025, 6:29 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG28f5e880e8b2: Use device_delete_children instead of explicit calls to device_delete_child.

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

aw_mmc.c

8 lines

arm64/

broadcom/

genet/

if_genet.c

5 lines

dev/

intpm/

intpm.c

3 lines

Diff 147636

View Options

sys/arm/allwinner/aw_mmc.c

View Options

sys/arm64/broadcom/genet/if_genet.c

View Options

Use device_delete_children instead of explicit calls to device_delete_childClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 147636

sys/arm/allwinner/aw_mmc.c

sys/arm64/broadcom/genet/if_genet.c

sys/dev/intpm/intpm.c

Use device_delete_children instead of explicit calls to device_delete_child
ClosedPublic
Actions

Revision Contents
Changeset List