Differential D41466

syslogd: Block timezone updating in capability mode
ClosedPublic
Actions

Authored by jfree on Aug 15 2023, 4:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 4, 1:13 AM

	Unknown Object (File)
	Mon, Aug 3, 7:47 AM

	Unknown Object (File)
	Mon, Aug 3, 6:34 AM

	Unknown Object (File)
	Sun, Aug 2, 6:29 AM

	Unknown Object (File)
	Fri, Jul 31, 11:17 PM

	Unknown Object (File)
	Mon, Jul 27, 4:56 PM

	Unknown Object (File)
	Mon, Jul 27, 2:36 PM

	Unknown Object (File)
	Sat, Jul 25, 4:42 PM

Subscribers

Details

Reviewers

Commits

rG24f4019b6a89: syslogd: Block timezone updating in capability mode

Summary

Do not update local timezone data upon reload when syslogd is compiled
with libcasper support. Timezone files are pre-fetched using the
caph_cache_tzdata() function before entering capability mode. Attempts
to re-fetch these files will result in a capability violation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jfree created this revision.Aug 15 2023, 4:10 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 15 2023, 4:10 AM

jfree requested review of this revision.Aug 15 2023, 4:10 AM

jfree added a parent revision: D41465: syslogd: Log messages using libcasper.

jfree added a child revision: D41467: syslogd: Enter capability mode.

markj added inline comments.Aug 23 2023, 3:28 PM

usr.sbin/syslogd/syslogd.c
2511	Let's put an XXX comment in here at least, since we'd like to fix this somehow. It'll require a new interface to the tzcode module.

Add XXX comment for needed future tzcode capability module

markj accepted this revision.Aug 24 2023, 2:13 PM

This revision is now accepted and ready to land.Aug 24 2023, 2:13 PM

Closed by commit rG24f4019b6a89: syslogd: Block timezone updating in capability mode (authored by jfree). · Explain WhyNov 27 2024, 10:28 PM

This revision was automatically updated to reflect the committed changes.

jfree added a commit: rG24f4019b6a89: syslogd: Block timezone updating in capability mode.

Revision Contents
Changeset List

Path

Size

usr.sbin/

syslogd/

6 lines

Diff 147095

usr.sbin/syslogd/syslogd.c

Loading...