Page MenuHomeFreeBSD
Differential D47672

vfs: Fix vop_stdis_text()
ClosedPublic
Actions

Authored by markj on Nov 19 2024, 2:56 PM.
Tags
None
Referenced Files
F169762041: D47672.id146691.diff
Wed, Sep 2, 11:57 AM
F169747799: D47672.diff
Wed, Sep 2, 11:04 AM
F169746594: D47672.id146706.diff
Wed, Sep 2, 10:59 AM
F169731973: D47672.id146723.diff
Wed, Sep 2, 9:59 AM
F169708972: D47672.id146716.diff
Wed, Sep 2, 8:39 AM
F169706308: D47672.id.diff
Wed, Sep 2, 8:31 AM
Unknown Object (File)
Mon, Aug 31, 10:06 AM
Unknown Object (File)
Mon, Aug 31, 8:40 AM
View All Files
Subscribers
imp
olce

Details

Reviewers
kib
kevans
ngie
Commits
rGe59a3bb02863: vfs: Fix vop_stdis_text()
rG4ff291ebe80a: vfs: Fix vop_stdis_text()
Summary

atomic(9) primitives are documented as operating on unsigned types.
Here, we need a cast to avoid a tautological comparison.

Reported by: NetApp
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.
Fixes: e511bd1406fa ("vfs: fully lockless v_writecount adjustment")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60694
Build 57578: arc lint + arc unit

Event Timeline

markj created this revision.Nov 19 2024, 2:56 PM
Herald added subscribers: olce, imp. · View Herald TranscriptNov 19 2024, 2:56 PM
markj requested review of this revision.Nov 19 2024, 2:56 PM
Harbormaster completed remote builds in B60685: Diff 146691.Nov 19 2024, 2:56 PM
kib accepted this revision.Nov 19 2024, 3:14 PM

So currently ETXTBSY does not work?

This revision is now accepted and ready to land.Nov 19 2024, 3:14 PM
markj added a comment.Nov 19 2024, 3:25 PM
In D47672#1087062, @kib wrote:

So currently ETXTBSY does not work?

It's not that bad. It means that access(write perms) will return 0 even if the file is being executed (it should return ETXTBUSY to userspace), but VOP_ADD_WRITECOUNT will still fail.

I will write a quick regression test.

markj updated this revision to Diff 146706.Nov 19 2024, 3:54 PM

Add a regression test

This revision now requires review to proceed.Nov 19 2024, 3:54 PM
Herald added a reviewer: ngie. · View Herald TranscriptNov 19 2024, 3:54 PM
Harbormaster completed remote builds in B60691: Diff 146706.Nov 19 2024, 3:54 PM
kib accepted this revision.Nov 19 2024, 4:01 PM
kib added inline comments.
contrib/netbsd-tests/lib/libc/sys/t_access.c
193

It might be somewhat harder to code, but use of sysctl kern.proc.pathname.-1 is more appropriate there IMO.

This revision is now accepted and ready to land.Nov 19 2024, 4:01 PM
markj updated this revision to Diff 146716.Nov 19 2024, 6:19 PM

Use sysctl.

This revision now requires review to proceed.Nov 19 2024, 6:19 PM
Harbormaster completed remote builds in B60694: Diff 146716.Nov 19 2024, 6:19 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 19 2024, 9:19 PM
Closed by commit rG4ff291ebe80a: vfs: Fix vop_stdis_text() (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4ff291ebe80a: vfs: Fix vop_stdis_text().
markj added a commit: rGe59a3bb02863: vfs: Fix vop_stdis_text().Nov 28 2024, 2:41 PM

Revision Contents
Changeset List

PathSize
contrib/
netbsd-tests/
lib/
libc/
sys/
35 lines
sys/
kern/
2 lines

Diff 146716

View Options

contrib/netbsd-tests/lib/libc/sys/t_access.c

Loading...
View Options

sys/kern/vfs_default.c

Loading...