release: Add missing dependencies in the minimal OCI image
ClosedPublic
Actions

Authored by dfr on Mon, Nov 18, 4:32 PM.

Details

Reviewers

cperciva
emaste
manu
bapt

Group Reviewers

releng

Commits

rG4a768794b836: release: Add missing dependencies in the minimal OCI image
rGca1f1d2c9419: release: Add missing dependencies in the minimal OCI image

Summary

The pkg-bootstrap binary depends on fetch.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60666
Build 57550: arc lint + arc unit

Event Timeline

dfr created this revision.Mon, Nov 18, 4:32 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMon, Nov 18, 4:32 PM

dfr requested review of this revision.Mon, Nov 18, 4:32 PM

Harbormaster completed remote builds in B60666: Diff 146648.Mon, Nov 18, 4:32 PM

dfr added reviewers: releng, cperciva.Mon, Nov 18, 4:36 PM

These seem like they should be dependencies of other packages? Or does pkgbase not register dependencies properly?

I guess fetch(1) does not require much extra space over libfetch in the FreeBSD-fetch pkg, so not a big deal.

This revision is now accepted and ready to land.Mon, Nov 18, 5:00 PM

Indeed FreeBSD-pkg-bootstrap should presumably depend on these three

In D47661#1086713, @emaste wrote:

Indeed FreeBSD-pkg-bootstrap should presumably depend on these three

This isn't a problem on 15-CURRENT so probably the dependencies are fixed there. Strictly speaking, this diff is not necessary for the main branch but its harmless so I plan to merge to main so that the OCI release bits don't diverge between main and stable/14.

This isn't a problem on 15-CURRENT so probably the dependencies are fixed there.

Oh, that makes sense. Once we know how the dependency works properly in main (@bapt, @manu?) we can omit this there.

I'm ok with this but let's give some pkgbase people a chance to comment in case this is something which should be fixed on their side.

bapt accepted this revision.Tue, Nov 19, 7:46 AM

zlei added a subscriber: zlei.Tue, Nov 19, 10:00 AM

I'm going to land this now with a short MFC timer. Still trying to figure out why current doesn't need this.

Closed by commit rGca1f1d2c9419: release: Add missing dependencies in the minimal OCI image (authored by dfr). · Explain WhyTue, Nov 19, 10:45 AM

This revision was automatically updated to reflect the committed changes.

dfr added a commit: rGca1f1d2c9419: release: Add missing dependencies in the minimal OCI image.

let's give some pkgbase people a chance to comment in case this is something which should be fixed on their side

It is apparently already fixed in main, but we don't know which commit is responsible. I think the plan will be to MFC this change, then once we find the appropriate main commit revert this with reference to it.

dfr added a commit: rG4a768794b836: release: Add missing dependencies in the minimal OCI image.Wed, Nov 20, 5:17 PM