Fix failure to add an interface prefix route when route with the same prefix is already presented in the routing table.
ClosedPublic
Actions

# route add -net 192.0.2.0/24 -interface vtnet0
add net 192.0.2.0: gateway vtnet0
# ifconfig epair create
epair0a
# ifconfig epair0a inet 192.0.2.1/24
# route show 192.0.2.0/24
   route to: 192.0.2.0
destination: 192.0.2.0
       mask: 255.255.255.0
        fib: 0
  interface: epair0a
      flags: <UP,DONE,PINNED>
 recvpipe  sendpipe  ssthresh  rtt,msec    mtu        weight    expire
       0         0         0         0      1500         1         0

Thank you!

zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.Nov 13 2024, 5:26 AM

ae accepted this revision as: ae.Nov 13 2024, 7:50 AM

This revision is now accepted and ready to land.Nov 13 2024, 7:50 AM

jlduran accepted this revision as: jlduran.Nov 13 2024, 5:03 PM

Closed by commit rG1da4954c92ea: Fix failure to add an interface prefix route when route with the same (authored by melifaro). · Explain WhyNov 13 2024, 9:04 PM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG1da4954c92ea: Fix failure to add an interface prefix route when route with the same.

Sigh, it looks like this commit broke the following test:
https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/lastCompletedBuild/testReport/junit/sys.net.routing.test_routing_l3/py/TestIfOps__test_change_prefix_route_inet_/
To reproduce:

# create two interfaces
if1=$(ifconfig epair create)
if2=$(ifconfig epair create)
# assign IP addresses in the same subnet
ifconfig $if1 inet 192.0.2.1/24
ifconfig $if2 inet 192.0.2.2/24
# Verify that the route points to the first interface (fails, as $if2 was added last, it points to $if2)
netstat -r4n | grep 192.0.2.0/24
# Remove the first interface
ifconfig $if1 destroy
# Verify that the route points to the second interface (it also fails, even if we remove $if2, we will have no route)
netstat -r4n | grep 192.0.2.0/24

jlduran mentioned this in D47585: tests: routing: Add address with same prefix present.Nov 15 2024, 12:33 AM

franco_opnsense.org mentioned this in D46301: netlink/route: make route deletion behavior match route(4) socket.Mon, Dec 2, 7:04 PM