arm64: Use the common activate function in nexus
ClosedPublic
Actions

Authored by andrew on Oct 25 2024, 2:20 PM.

Details

Reviewers

jhb
cperciva
manu

Group Reviewers

arm64

Commits

rG60344d7e09d5: arm64: Use the common activate function in nexus

Summary

For non-memory and non-ioport spaces use the common
bus_generic_rman_activate_resource function in the arm64 nexus. We
can't currently use it for memory types as it doesn't support
non-posted memory.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60190
Build 57074: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 25 2024, 2:20 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 25 2024, 2:20 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Oct 25 2024, 2:20 PM

andrew added a parent revision: D47282: bus: Activate INTRNG interrupts in common code.

Harbormaster completed remote builds in B60190: Diff 145457.Oct 25 2024, 2:20 PM

andrew added a reviewer: arm64.Oct 25 2024, 2:20 PM

Is the same change needed for nexus drivers on other INTRNG platforms? I guess it isn't required, per se, but it is a nice cleanup to reduce duplicated code?

This revision is now accepted and ready to land.Oct 25 2024, 4:21 PM

I think the other drivers can use bus_generic_rman_activate_resource directly, however I can't easily test them.

Should I be testing this on Graviton (with my _AEI patches minus the bogus resource activation one)?

+1 for deduplication

sys/arm64/arm64/nexus.c
362	Isn't removing intr_activate_irq() a mistake? I can't find who calls it after the patch...

In D47283#1078259, @cperciva wrote:

Should I be testing this on Graviton (with my _AEI patches minus the bogus resource activation one)?

This one is optional, it's a cleanup after merging common code.

sys/arm64/arm64/nexus.c
362	See D47282

Closed by commit rG60344d7e09d5: arm64: Use the common activate function in nexus (authored by andrew). · Explain WhyOct 29 2024, 10:35 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG60344d7e09d5: arm64: Use the common activate function in nexus.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

nexus.c

37 lines

Diff 145457

View Options

arm64: Use the common activate function in nexusClosedPublicActions