bus: Activate INTRNG interrupts in common code
AcceptedPublic
Actions

Authored by andrew on Fri, Oct 25, 2:20 PM.

Details

Reviewers

jhb
cperciva

Summary

We need to call into INTRNG to activate an interrupt on platforms that
use it. When bus_generic_rman_activate_resource was added. As this
is only a problem for buses that manage their own IRQ space this was
only a problem for gpiobus as it creates interrupts for each GPIO pin.

Reported by: cperciva
Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 60189
Build 57073: arc lint + arc unit

Event Timeline

andrew created this revision.Fri, Oct 25, 2:20 PM

Herald added subscribers: olce, loos, imp. · View Herald TranscriptFri, Oct 25, 2:20 PM

andrew requested review of this revision.Fri, Oct 25, 2:20 PM

Harbormaster completed remote builds in B60189: Diff 145456.Fri, Oct 25, 2:20 PM

andrew added a child revision: D47283: arm64: Use the common activate function in nexus.Fri, Oct 25, 2:20 PM

andrew mentioned this in D47252: acpi_gpiobus: Use non-rman resource activation.Fri, Oct 25, 2:29 PM

The commit log doesn't read quite correct. I would suggest something like:

We need to call into INTRNG to activate all interrupts on platforms that
use it.  Currently, interrupts are only activated in the nexus drivers for
INTRNG platforms, but this does not handle other bus devices such as
gpiobus that manage their own IRQ space.

This revision is now accepted and ready to land.Fri, Oct 25, 4:19 PM

andrew mentioned this in D47283: arm64: Use the common activate function in nexus.Fri, Oct 25, 5:16 PM