Page MenuHomeFreeBSD

bus: Activate INTRNG interrupts in common code
ClosedPublic

Authored by andrew on Oct 25 2024, 2:20 PM.
Tags
None
Referenced Files
F106197903: D47282.diff
Fri, Dec 27, 12:30 AM
Unknown Object (File)
Mon, Dec 9, 1:47 AM
Unknown Object (File)
Tue, Dec 3, 11:01 PM
Unknown Object (File)
Nov 18 2024, 10:00 PM
Unknown Object (File)
Nov 10 2024, 3:29 PM
Unknown Object (File)
Nov 10 2024, 9:15 AM
Unknown Object (File)
Nov 6 2024, 10:20 AM
Unknown Object (File)
Nov 4 2024, 12:07 AM
Subscribers

Details

Summary

We need to call into INTRNG to activate an interrupt on platforms that
use it. When bus_generic_rman_activate_resource was added. As this
is only a problem for buses that manage their own IRQ space this was
only a problem for gpiobus as it creates interrupts for each GPIO pin.

Reported by: cperciva
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60189
Build 57073: arc lint + arc unit

Event Timeline

The commit log doesn't read quite correct. I would suggest something like:

We need to call into INTRNG to activate all interrupts on platforms that
use it.  Currently, interrupts are only activated in the nexus drivers for
INTRNG platforms, but this does not handle other bus devices such as
gpiobus that manage their own IRQ space.
This revision is now accepted and ready to land.Oct 25 2024, 4:19 PM

This + D47253 makes EC2's GPIO "power button" work for me. Please commit (and MFC soon)!

This + D47253 makes EC2's GPIO "power button" work for me. Please commit (and MFC soon)!

Looks like the MFC isn't entirely trivial due to a bunch of changes @jhb has made since stable/14 branched. John, am I right in thinking that your changes in subr_bus.c won't be landing in stable/14?

I am not planning to merge for 14.2, no. There were many changes tied up in the refactoring of the bus resource management in 15.