ACPI: Implement power button on !x86
ClosedPublic
Actions

Authored by cperciva on Oct 12 2024, 5:33 PM.

Details

Reviewers

andrew
val_packett.cool

Commits

rGc90ebd3fa356: ACPI: Implement power button on !x86
rGe177e6429455: ACPI: Implement power button on !x86
rGf41ef9d80b3d: ACPI: Implement power button on !x86

Summary

ACPI sleep states are only implemented on x86 systems, so having the
ACPI power button attempt to enter "S5" (or other state as configured
via the hw.acpi.power_button_state sysctl) is not useful.

On non-x86 systems, implement the power button with a call to

shutdown_nice(RB_POWEROFF)

to shut down the system.

Sponsored by: Amazon
Tested on: Graviton 2
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Oct 12 2024, 5:33 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 12 2024, 5:33 PM

cperciva requested review of this revision.Oct 12 2024, 5:33 PM

Harbormaster completed remote builds in B59944: Diff 144729.Oct 12 2024, 5:33 PM

I could add a sysctl to disable this if anyone thinks that making the power button not power-off the system would be a useful option.

It looks like this would fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273756

In D47094#1073271, @andrew wrote:

It looks like this would fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273756

Maybe? There are a number of different ways to tell a system to turn off, so I don't know for certain whether the ACPI shutdown event from QEMU is this particular one.

andrew accepted this revision.Oct 17 2024, 10:05 AM

This revision is now accepted and ready to land.Oct 17 2024, 10:05 AM

Closed by commit rGf41ef9d80b3d: ACPI: Implement power button on !x86 (authored by cperciva). · Explain WhyOct 22 2024, 2:56 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rGf41ef9d80b3d: ACPI: Implement power button on !x86.

cperciva added a commit: rGe177e6429455: ACPI: Implement power button on !x86.Nov 3 2024, 4:03 PM

cperciva added a commit: rGc90ebd3fa356: ACPI: Implement power button on !x86.Nov 3 2024, 4:17 PM