if_ovpn: ensure it's safe to modify the mbuf
ClosedPublic
Actions

Authored by kp on Sep 4 2024, 12:56 PM.

Tags

None

Referenced Files

	F102134648: D46529.id142854.diff
	Fri, Nov 8, 1:18 AM

	Unknown Object (File)
	Thu, Nov 7, 11:35 AM

	Unknown Object (File)
	Thu, Nov 7, 11:34 AM

	Unknown Object (File)
	Thu, Nov 7, 11:34 AM

	Unknown Object (File)
	Thu, Nov 7, 11:34 AM

	Unknown Object (File)
	Tue, Nov 5, 8:00 PM

	Unknown Object (File)
	Tue, Nov 5, 5:22 PM

	Unknown Object (File)
	Wed, Oct 30, 12:19 PM

Subscribers

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG8f2519378501: if_ovpn: ensure it's safe to modify the mbuf
rG5644e2c6d47c: if_ovpn: ensure it's safe to modify the mbuf

Summary

PR: 280036
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59297
Build 56184: arc lint + arc unit

Event Timeline

kp created this revision.Sep 4 2024, 12:56 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptSep 4 2024, 12:56 PM

kp requested review of this revision.Sep 4 2024, 12:56 PM

Harbormaster completed remote builds in B59296: Diff 142853.Sep 4 2024, 12:56 PM

Probably for network related code ENOBUFS is better than ENOMEM.

ENOMEM -> ENOBUFS

Harbormaster completed remote builds in B59297: Diff 142854.Sep 4 2024, 1:47 PM

ae accepted this revision.Sep 5 2024, 7:56 AM

This revision is now accepted and ready to land.Sep 5 2024, 7:56 AM

Closed by commit rG5644e2c6d47c: if_ovpn: ensure it's safe to modify the mbuf (authored by kp). · Explain WhySep 5 2024, 9:00 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG5644e2c6d47c: if_ovpn: ensure it's safe to modify the mbuf.

kp added a commit: rG8f2519378501: if_ovpn: ensure it's safe to modify the mbuf.Sep 12 2024, 11:53 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if_ovpn.c

12 lines

Diff 142854

View Options

if_ovpn: ensure it's safe to modify the mbufClosedPublicActions