Page MenuHomeFreeBSD
Differential D46389

dev_pager: define free_page for mgt devices
ClosedPublic
Actions

Authored by dougm on Aug 21 2024, 2:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 3:27 PM
Unknown Object (File)
Apr 20 2026, 6:46 PM
Unknown Object (File)
Apr 20 2026, 12:43 PM
Unknown Object (File)
Apr 18 2026, 12:02 PM
Unknown Object (File)
Apr 18 2026, 11:29 AM
Unknown Object (File)
Apr 18 2026, 11:16 AM
Unknown Object (File)
Apr 17 2026, 7:24 PM
Unknown Object (File)
Apr 16 2026, 10:41 AM
View All Files
Subscribers
ehem_freebsd_m5p.com
emaste
imp
linuxkpi

Details

Reviewers
alc
kib
andrew
Commits
rGd48524e21f1a: dev_pager: define free_page for mgt devices
Summary

Callers of cdev_pager_free_page always have object->type == OBJT_MGTDEVICE. Define a function for them to call that skips the runtime type check.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Aug 21 2024, 2:07 AM
Herald added a reviewer: andrew. · View Herald TranscriptAug 21 2024, 2:07 AM
Herald added subscribers: linuxkpi, ehem_freebsd_m5p.com, emaste. · View Herald Transcript
dougm requested review of this revision.Aug 21 2024, 2:07 AM
kib added inline comments.Aug 21 2024, 5:01 PM
sys/vm/device_pager.c
264–265

I do not see much reason to keep this assert, both callees are asserting the same lock.

275

I suggest to keep the cdev_ name prefix. Like cdev_mgtdev_pager_free_page()

dougm updated this revision to Diff 142317.Aug 21 2024, 5:11 PM
dougm marked 2 inline comments as done.

Accept all suggestions.

kib accepted this revision.Aug 21 2024, 5:13 PM
This revision is now accepted and ready to land.Aug 21 2024, 5:13 PM
Closed by commit rGd48524e21f1a: dev_pager: define free_page for mgt devices (authored by dougm). · Explain WhyAug 21 2024, 8:50 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGd48524e21f1a: dev_pager: define free_page for mgt devices.
Herald added a subscriber: imp. · View Herald TranscriptAug 21 2024, 8:50 PM

Revision Contents
Changeset List

PathSize
sys/
arm/
nvidia/
drm2/
2 lines
compat/
linuxkpi/
common/
src/
2 lines
dev/
drm2/
ttm/
2 lines
xen/
gntdev/
2 lines
privcmd/
2 lines
vm/
24 lines
1 line

Diff 142317

View Options

sys/arm/nvidia/drm2/tegra_bo.c

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_page.c

Loading...
View Options

sys/dev/drm2/ttm/ttm_bo_vm.c

Loading...
View Options

sys/dev/xen/gntdev/gntdev.c

Loading...
View Options

sys/dev/xen/privcmd/privcmd.c

Loading...
View Options

sys/vm/device_pager.c

Loading...
View Options

sys/vm/vm_pager.h

Loading...