Page MenuHomeFreeBSD
Differential D46153

buf_ring: Remove old arm-only dequeue code
ClosedPublic
Actions

Authored by andrew on Jul 26 2024, 8:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 6, 1:13 PM
Unknown Object (File)
Mon, May 4, 1:23 AM
Unknown Object (File)
Sun, May 3, 5:54 PM
Unknown Object (File)
Sun, May 3, 8:30 AM
Unknown Object (File)
Thu, Apr 30, 12:37 AM
Unknown Object (File)
Mon, Apr 27, 1:19 PM
Unknown Object (File)
Apr 21 2026, 12:26 AM
Unknown Object (File)
Apr 21 2026, 12:25 AM
View All 87 Files
Subscribers
imp

Details

Reviewers
cperciva
markj
kib
alc
imp
Commits
rGb5410efe42c5: buf_ring: Remove old arm-only dequeue code
rG14c779e5caf0: buf_ring: Remove old arm-only dequeue code
rG7eb0fffc7792: buf_ring: Remove old arm-only dequeue code
Summary

In the single consumer dequeue the consumer thread controls
br_cons_head. As such no ordering between this and other data are
required.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58848
Build 55735: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 26 2024, 8:56 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 26 2024, 8:56 AM
andrew requested review of this revision.Jul 26 2024, 8:56 AM
Harbormaster completed remote builds in B58848: Diff 141422.Jul 26 2024, 8:56 AM
andrew added a parent revision: D46152: buf_ring: Use atomic operations with br_cons_tail.Jul 26 2024, 8:56 AM
andrew added a child revision: D46154: buf_ring: Use atomic operations with br_prod_tail.
markj accepted this revision.Jul 26 2024, 12:57 PM
This revision is now accepted and ready to land.Jul 26 2024, 12:57 PM
imp accepted this revision.Jul 26 2024, 1:28 PM

There's other inconsistent stuff here, but this looks save since the data is protected by a lock.

imp added a comment.Jul 26 2024, 1:34 PM
In D46153#1052004, @imp wrote:

There's other inconsistent stuff here, but this looks save since the data is protected by a lock.

Oh i see the other reviews and I see markj flagged the main one i saw

kib accepted this revision.Jul 26 2024, 9:13 PM
alc accepted this revision.Jul 29 2024, 12:51 AM
Closed by commit rG7eb0fffc7792: buf_ring: Remove old arm-only dequeue code (authored by andrew). · Explain WhyAug 19 2024, 11:04 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG7eb0fffc7792: buf_ring: Remove old arm-only dequeue code.
andrew added a commit: rG14c779e5caf0: buf_ring: Remove old arm-only dequeue code.Sep 2 2024, 8:51 AM
andrew added a commit: rGb5410efe42c5: buf_ring: Remove old arm-only dequeue code.Sep 2 2024, 9:13 AM

Revision Contents
Changeset List

PathSize
sys/
sys/
29 lines

Diff 141422

View Options

sys/sys/buf_ring.h

Loading...