Page MenuHomeFreeBSD

include: ssp: fortify <sys/random.h>
AcceptedPublic

Authored by kevans on Fri, Jun 21, 5:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 5:29 PM
Unknown Object (File)
Thu, Jun 27, 6:53 PM
Unknown Object (File)
Thu, Jun 27, 2:14 PM
Unknown Object (File)
Sun, Jun 23, 4:56 PM
Subscribers

Details

Reviewers
kib
markj
Group Reviewers
Klara
Summary

That is to say, fortify getrandom(2).

Sponsored by: Stormshield
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58292
Build 55180: arc lint + arc unit

Event Timeline

Does it make sense in general to fortify non-standard interfaces like arc4random_buf()?

This revision is now accepted and ready to land.Tue, Jul 2, 2:25 PM

Does it make sense in general to fortify non-standard interfaces like arc4random_buf()?

I'm curious to hear your thoughts here, because I hadn't considered there may be a reason not to -- their uses are still susceptible to the same kind of easy-to-catch bugs you might make with many of the standardized interfaces, so if they don't add much complexity I assumed it was worth it even if they're not often-used.

Does it make sense in general to fortify non-standard interfaces like arc4random_buf()?

I'm curious to hear your thoughts here, because I hadn't considered there may be a reason not to -- their uses are still susceptible to the same kind of easy-to-catch bugs you might make with many of the standardized interfaces, so if they don't add much complexity I assumed it was worth it even if they're not often-used.

Am I right that this patch series doesn't fortify arc4random_buf(), or did I just miss it? I'd assume it's worth it as well, I don't see a downside.

Does it make sense in general to fortify non-standard interfaces like arc4random_buf()?

I'm curious to hear your thoughts here, because I hadn't considered there may be a reason not to -- their uses are still susceptible to the same kind of easy-to-catch bugs you might make with many of the standardized interfaces, so if they don't add much complexity I assumed it was worth it even if they're not often-used.

Am I right that this patch series doesn't fortify arc4random_buf(), or did I just miss it? I'd assume it's worth it as well, I don't see a downside.

Oh, sorry, it's over in https://reviews.freebsd.org/D45681

Does it make sense in general to fortify non-standard interfaces like arc4random_buf()?

I'm curious to hear your thoughts here, because I hadn't considered there may be a reason not to -- their uses are still susceptible to the same kind of easy-to-catch bugs you might make with many of the standardized interfaces, so if they don't add much complexity I assumed it was worth it even if they're not often-used.

Am I right that this patch series doesn't fortify arc4random_buf(), or did I just miss it? I'd assume it's worth it as well, I don't see a downside.

Oh, sorry, it's over in https://reviews.freebsd.org/D45681

I did miss it, my bad. I had just forgotten about that patch.