Page MenuHomeFreeBSD
Differential D45680

include: ssp: fortify poll/ppoll from <poll.h>
AcceptedPublic
Actions

Authored by kevans on Fri, Jun 21, 4:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 7:41 AM
Unknown Object (File)
Sat, Jun 29, 12:16 AM
Unknown Object (File)
Thu, Jun 27, 3:21 PM
Unknown Object (File)
Sun, Jun 23, 6:39 PM
Subscribers
imp

Details

Reviewers
kib
markj
Group Reviewers
Klara
Summary

For poll/ppoll we just need to bounds-check the poll array that we're
about to write out to.

Sponsored by: Stormshieled
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58366
Build 55254: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, Jun 21, 4:59 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 21, 4:59 PM
kevans requested review of this revision.Fri, Jun 21, 4:59 PM
Harbormaster completed remote builds in B58289: Diff 140081.Fri, Jun 21, 4:59 PM
kevans added a parent revision: D45679: include: ssp: round out fortification of current set of headers.Fri, Jun 21, 4:59 PM
kevans added a child revision: D45681: include: ssp: fortify <stdlib.h>.
markj added inline comments.Mon, Jun 24, 4:54 PM
include/ssp/poll.h
3

Extra line here.

lib/libc/sys/ppoll.c
40–41

This line is too long.

markj accepted this revision as: markj.Mon, Jun 24, 4:54 PM
This revision is now accepted and ready to land.Mon, Jun 24, 4:54 PM
kevans marked 2 inline comments as done.Wed, Jun 26, 7:11 PM
kevans added inline comments.
include/ssp/poll.h
3

Addressed here and all of the other headers since these were all copy/paste into each other.

kevans updated this revision to Diff 140280.Wed, Jun 26, 7:12 PM
kevans marked an inline comment as done.

Address review feedback

This revision now requires review to proceed.Wed, Jun 26, 7:12 PM
Harbormaster completed remote builds in B58366: Diff 140280.Wed, Jun 26, 7:12 PM
kib accepted this revision.Thu, Jun 27, 3:14 PM
This revision is now accepted and ready to land.Thu, Jun 27, 3:14 PM

Revision Contents
Changeset List

PathSize
include/
ssp/
2 lines
62 lines
lib/
libc/
sys/
5 lines
8 lines
tests/
secure/
1 line
fortify_poll_test.c
fortify_strings_test.c
34 lines
sys/
sys/
4 lines

Diff 140280

View Options

include/ssp/Makefile

Loading...
View Options

include/ssp/poll.h

Loading...
View Options

lib/libc/sys/poll.c

Loading...
View Options

lib/libc/sys/ppoll.c

Loading...
View Options

lib/libc/tests/secure/Makefile

Loading...
View Options

lib/libc/tests/secure/fortify_poll_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_stdio_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_string_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_strings_test.c

Loading...
View Options

lib/libc/tests/secure/fortify_unistd_test.c

Loading...
View Options

lib/libc/tests/secure/generate-fortify-tests.lua

Loading...
View Options

sys/sys/poll.h

Loading...