Page MenuHomeFreeBSD

include: ssp: fortify poll/ppoll from <poll.h>
ClosedPublic

Authored by kevans on Jun 21 2024, 4:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 19, 4:36 PM
Unknown Object (File)
Sun, Oct 19, 4:36 PM
Unknown Object (File)
Sun, Oct 19, 4:36 PM
Unknown Object (File)
Sun, Oct 19, 4:36 PM
Unknown Object (File)
Sun, Oct 19, 2:22 AM
Unknown Object (File)
Fri, Oct 17, 10:06 PM
Unknown Object (File)
Mon, Oct 13, 5:39 AM
Unknown Object (File)
Sun, Oct 12, 3:40 PM
Subscribers

Details

Summary

For poll/ppoll we just need to bounds-check the poll array that we're
about to write out to.

Sponsored by: Stormshieled
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58289
Build 55177: arc lint + arc unit

Event Timeline

include/ssp/poll.h
2

Extra line here.

lib/libc/sys/ppoll.c
41

This line is too long.

This revision is now accepted and ready to land.Jun 24 2024, 4:54 PM
kevans added inline comments.
include/ssp/poll.h
2

Addressed here and all of the other headers since these were all copy/paste into each other.

kevans marked an inline comment as done.

Address review feedback

This revision now requires review to proceed.Jun 26 2024, 7:12 PM
This revision is now accepted and ready to land.Jun 27 2024, 3:14 PM