unix: use m_freemp() when disposing unix socket buffers
ClosedPublic
Actions

Authored by glebius on Jun 3 2024, 8:12 PM.

Details

Reviewers

markj
khng

Commits

rGf70581ff7d55: unix: use m_freemp() when disposing unix socket buffers
rGa9b55a66440c: unix: use m_freemp() when disposing unix socket buffers

Summary

The new unix/dgram uses m_nextpkt linkage, while the old unix/stream
uses m_next linkage. This fixes memory leak.

PR: 279467
MFC After: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58044
Build 54932: arc lint + arc unit

Event Timeline

glebius created this revision.Jun 3 2024, 8:12 PM

Herald added subscribers: olce, imp. · View Herald TranscriptJun 3 2024, 8:12 PM

glebius requested review of this revision.Jun 3 2024, 8:12 PM

Harbormaster completed remote builds in B58044: Diff 139409.Jun 3 2024, 8:12 PM

glebius added a parent revision: D45477: mbuf: provide m_freemp().Jun 3 2024, 8:12 PM

glebius mentioned this in D45443: unix/dgram: dispose mbufs on uxdg_mb queue.Jun 3 2024, 8:12 PM

khng accepted this revision.Jun 3 2024, 8:15 PM

This revision is now accepted and ready to land.Jun 3 2024, 8:15 PM

It would be nice to include Diagnosed by: khng or similar, and a Fixes: tag.

Closed by commit rGa9b55a66440c: unix: use m_freemp() when disposing unix socket buffers (authored by glebius). · Explain WhyJun 4 2024, 12:23 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGa9b55a66440c: unix: use m_freemp() when disposing unix socket buffers.

glebius added a commit: rGf70581ff7d55: unix: use m_freemp() when disposing unix socket buffers.Tue, Jun 11, 1:34 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_usrreq.c

4 lines

Diff 139409

View Options

unix: use m_freemp() when disposing unix socket buffersClosedPublicActions