Paths

Table of Contentst

Differential D45478

unix: use m_freemp() when disposing unix socket buffers
ClosedPublic
Actions

Authored by glebius on Mon, Jun 3, 8:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 15, 8:48 PM

	Unknown Object (File)
	Fri, Jun 14, 4:34 PM

	Unknown Object (File)
	Fri, Jun 7, 7:48 AM

	Unknown Object (File)
	Fri, Jun 7, 7:48 AM

	Unknown Object (File)
	Fri, Jun 7, 7:48 AM

	Unknown Object (File)
	Thu, Jun 6, 4:32 AM

	Unknown Object (File)
	Wed, Jun 5, 6:43 PM

	Unknown Object (File)
	Tue, Jun 4, 1:41 AM

View All 11 Files

Subscribers

Details

Reviewers

markj
khng

Commits

rGf70581ff7d55: unix: use m_freemp() when disposing unix socket buffers
rGa9b55a66440c: unix: use m_freemp() when disposing unix socket buffers

Summary

The new unix/dgram uses m_nextpkt linkage, while the old unix/stream
uses m_next linkage. This fixes memory leak.

PR: 279467
MFC After: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mon, Jun 3, 8:12 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jun 3, 8:12 PM

glebius requested review of this revision.Mon, Jun 3, 8:12 PM

Harbormaster completed remote builds in B58044: Diff 139409.Mon, Jun 3, 8:12 PM

glebius added a parent revision: D45477: mbuf: provide m_freemp().Mon, Jun 3, 8:12 PM

glebius mentioned this in D45443: unix/dgram: dispose mbufs on uxdg_mb queue.Mon, Jun 3, 8:12 PM

khng accepted this revision.Mon, Jun 3, 8:15 PM

This revision is now accepted and ready to land.Mon, Jun 3, 8:15 PM

It would be nice to include Diagnosed by: khng or similar, and a Fixes: tag.

Closed by commit rGa9b55a66440c: unix: use m_freemp() when disposing unix socket buffers (authored by glebius). · Explain WhyTue, Jun 4, 12:23 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGa9b55a66440c: unix: use m_freemp() when disposing unix socket buffers.

glebius added a commit: rGf70581ff7d55: unix: use m_freemp() when disposing unix socket buffers.Tue, Jun 11, 1:34 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

4 lines

Diff 139413

sys/kern/uipc_usrreq.c

Loading...