Differential D45477

mbuf: provide m_freemp()
ClosedPublic
Actions

Authored by glebius on Mon, Jun 3, 8:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 7, 7:47 AM

	Unknown Object (File)
	Fri, Jun 7, 7:46 AM

	Unknown Object (File)
	Fri, Jun 7, 7:46 AM

	Unknown Object (File)
	Thu, Jun 6, 4:31 AM

	Unknown Object (File)
	Wed, Jun 5, 10:51 PM

	Unknown Object (File)
	Wed, Jun 5, 5:10 PM

	Unknown Object (File)
	Tue, Jun 4, 12:23 AM

	Unknown Object (File)
	Mon, Jun 3, 9:44 PM

View All 9 Files

Subscribers

Details

Reviewers

markj
khng

Commits

rGa3f7b81fdd22: mbuf: provide m_freemp()
rGbadf44cc2124: mbuf: provide m_freemp()

Summary

This function follows both m_nextpkt and m_next linkage freeing all mbufs.
Note that existing m_freem() follows only m_next.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mon, Jun 3, 8:12 PM

Herald added subscribers: olce, imp. · View Herald TranscriptMon, Jun 3, 8:12 PM

glebius requested review of this revision.Mon, Jun 3, 8:12 PM

Harbormaster completed remote builds in B58043: Diff 139408.Mon, Jun 3, 8:12 PM

glebius added a child revision: D45478: unix: use m_freemp() when disposing unix socket buffers.Mon, Jun 3, 8:12 PM

glebius mentioned this in D45443: unix/dgram: dispose mbufs on uxdg_mb queue.Mon, Jun 3, 8:12 PM

khng accepted this revision.Mon, Jun 3, 8:15 PM

This revision is now accepted and ready to land.Mon, Jun 3, 8:15 PM

markj added inline comments.Mon, Jun 3, 8:29 PM

sys/kern/kern_mbuf.c
1595	m_freem() lets you pass NULL, but this function does not. Is that deliberate?

glebius added inline comments.Tue, Jun 4, 12:12 AM

sys/kern/kern_mbuf.c
1595	Yes. I believe a good code should not call free(NULL). Of course we are obliged to support free(NULL) in userland and in kernel as well as some other freeing functions, e.g. m_freem(). I will provide a comment on top of m_freemp() that it doesn't support NULL argument.

Closed by commit rGbadf44cc2124: mbuf: provide m_freemp() (authored by glebius). · Explain WhyTue, Jun 4, 12:23 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGbadf44cc2124: mbuf: provide m_freemp().

glebius added a commit: rGa3f7b81fdd22: mbuf: provide m_freemp().Tue, Jun 11, 1:34 AM

Revision Contents
Changeset List

Path

Size

sys/

kern/

19 lines

3 lines

sys/

2 lines

Diff 139412

sys/kern/kern_mbuf.c

Loading...

sys/kern/uipc_mbuf.c

Loading...

sys/sys/mbuf.h

Loading...