Page MenuHomeFreeBSD

mbuf: provide m_freemp()
ClosedPublic

Authored by glebius on Jun 3 2024, 8:12 PM.
Tags
None
Referenced Files
F156698122: D45477.id139412.diff
Fri, May 15, 6:27 PM
Unknown Object (File)
Sat, May 9, 7:35 AM
Unknown Object (File)
Sat, May 9, 7:30 AM
Unknown Object (File)
Wed, May 6, 2:24 AM
Unknown Object (File)
Thu, Apr 30, 6:26 PM
Unknown Object (File)
Thu, Apr 23, 2:14 PM
Unknown Object (File)
Tue, Apr 21, 4:39 AM
Unknown Object (File)
Tue, Apr 21, 4:30 AM
Subscribers

Details

Summary

This function follows both m_nextpkt and m_next linkage freeing all mbufs.
Note that existing m_freem() follows only m_next.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 3 2024, 8:15 PM
sys/kern/kern_mbuf.c
1595

m_freem() lets you pass NULL, but this function does not. Is that deliberate?

sys/kern/kern_mbuf.c
1595

Yes. I believe a good code should not call free(NULL). Of course we are obliged to support free(NULL) in userland and in kernel as well as some other freeing functions, e.g. m_freem(). I will provide a comment on top of m_freemp() that it doesn't support NULL argument.

This revision was automatically updated to reflect the committed changes.