Page MenuHomeFreeBSD
Differential D45157

Increase IOAPIC_MAX_ID to 255 (from 254)
ClosedPublic
Actions

Authored by emaste on May 10 2024, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 11, 1:36 PM
Unknown Object (File)
Sat, Apr 11, 8:05 AM
Unknown Object (File)
Fri, Apr 10, 1:55 PM
Unknown Object (File)
Fri, Apr 10, 2:03 AM
Unknown Object (File)
Thu, Apr 9, 7:54 PM
Unknown Object (File)
Thu, Apr 9, 4:09 AM
Unknown Object (File)
Sat, Apr 4, 11:37 AM
Unknown Object (File)
Sat, Apr 4, 4:30 AM
View All Files
Subscribers
imp

Details

Reviewers
jhb
royger
kib
Commits
rGf952f27731ee: Increase IOAPIC_MAX_ID to 255 (from 254)
rG147c7e4dde23: Increase IOAPIC_MAX_ID to 255 (from 254)
rG18119e711f1c: Increase IOAPIC_MAX_ID to 255 (from 254)
rG4e3286818327: Increase IOAPIC_MAX_ID to 255 (from 254)
Summary

A test system here panicked with "madt_parse_apics: I/O APIC ID 255 too high". I/O APIC ID 255 is permissible.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.May 10 2024, 6:10 PM
emaste created this revision.
kib accepted this revision.May 10 2024, 6:16 PM
This revision is now accepted and ready to land.May 10 2024, 6:16 PM
jhb accepted this revision.May 10 2024, 7:03 PM

Might want a comment or a detail in the commit log that while the 0xff ID is used for broadcast IPIs for local APICs when not using x2APIC, IPIs aren't sent to I/O APICs, so it's ok for an I/O APIC to reuse that ID. Might also want to note that I/O APIC IDs haven't been meaningful since the 3-wire APIC bus which was last used by systems using Pentium CPUs.

emaste updated this revision to Diff 138376.May 10 2024, 7:30 PM

Add comment suggested by @jhb

This revision now requires review to proceed.May 10 2024, 7:30 PM
jhb accepted this revision.May 10 2024, 7:38 PM
This revision is now accepted and ready to land.May 10 2024, 7:38 PM
Closed by commit rG4e3286818327: Increase IOAPIC_MAX_ID to 255 (from 254) (authored by emaste). · Explain WhyMay 10 2024, 7:40 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG4e3286818327: Increase IOAPIC_MAX_ID to 255 (from 254).
Herald added a subscriber: imp. · View Herald TranscriptMay 10 2024, 7:40 PM
emaste added a commit: rG18119e711f1c: Increase IOAPIC_MAX_ID to 255 (from 254).May 15 2024, 5:21 PM
emaste added a commit: rG147c7e4dde23: Increase IOAPIC_MAX_ID to 255 (from 254).May 16 2024, 12:23 PM
emaste added a commit: rGf952f27731ee: Increase IOAPIC_MAX_ID to 255 (from 254).May 27 2024, 3:41 PM

Revision Contents
Changeset List

PathSize
sys/
x86/
include/
7 lines

Diff 138376

View Options

sys/x86/include/apicvar.h

Loading...