Paths

Table of Contentst

Differential D44394

Updating glabel.8 man page
Needs RevisionPublic
Actions

Authored by freebsd_ny-central.org on Mar 16 2024, 8:04 PM.

Tags

Referenced Files

	F83590008: D44394.diff
	Sun, May 12, 8:36 AM

	F83589984: D44394.diff
	Sun, May 12, 8:35 AM

	Unknown Object (File)
	Thu, May 9, 8:08 PM

	Unknown Object (File)
	Thu, May 9, 12:02 PM

	Unknown Object (File)
	Tue, May 7, 4:20 PM

	Unknown Object (File)
	Thu, May 2, 2:09 AM

	Unknown Object (File)
	Sat, Apr 27, 1:32 AM

	Unknown Object (File)
	Sat, Apr 27, 12:10 AM

View All 15 Files

Subscribers

Details

Reviewers

jrm
gbe

Group Reviewers

Summary

PR 276724 indicates that the current glabel man page does not describe the corner case of attempting to set a label on an already mounted partition.

Added a paragraph indicating that glabel requires an exclusive lock on the partition
Added that any file system first needs to be unmounted for the label to persist across reboot
Added that if the affected device node is root, that single user mode with r/o mount will be required

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

freebsd_ny-central.org created this revision.Mar 16 2024, 8:04 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2024, 8:04 PM

freebsd_ny-central.org requested review of this revision.Mar 16 2024, 8:04 PM

jrm added inline comments.Mar 19 2024, 7:45 PM

lib/geom/label/glabel.8
178
179	There's trailing whitespace at the end of the line after `file system`.
180

Thanks for the reminder and for the feedback. I've fixed the trailing whitespace now.

Aaand I missed the other two changes. Now added those as well.

freebsd_ny-central.org marked 2 inline comments as done.Thu, Apr 25, 4:10 PM

freebsd_ny-central.org added a reviewer: manpages.Sat, Apr 27, 1:51 PM

LGTM from manpages

This revision is now accepted and ready to land.Sun, May 12, 8:34 AM

The comments are marked as done but the differential itself doesn't contain them. For example the typo s/hols/holds/.

If they are included I would commit.

This revision now requires changes to proceed.Sun, May 12, 8:37 AM

Revision Contents
Changeset List

Path

Size

lib/

geom/

label/

9 lines

Diff 137666

lib/geom/label/glabel.8

Loading...