Page MenuHomeFreeBSD

Update glabel(8) to clarify filesystem volume labels, device metadata identifiers, and generic GEOM labels.
Needs ReviewPublic

Authored by bcr on Jun 25 2025, 2:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 3, 10:14 PM
Unknown Object (File)
Sun, Aug 2, 11:38 AM
Unknown Object (File)
Sat, Aug 1, 8:42 AM
Unknown Object (File)
Sat, Aug 1, 8:26 AM
Unknown Object (File)
Sat, Aug 1, 6:56 AM
Unknown Object (File)
Sat, Aug 1, 6:02 AM
Unknown Object (File)
Fri, Jul 31, 5:05 PM
Unknown Object (File)
Fri, Jul 31, 9:53 AM
Subscribers

Details

Reviewers
felix.the.red_gmail.com
Group Reviewers
manpages
Summary
  • Change description of manual page
  • Split out filesystem, GPT and GEOM labels.
  • Give an example for each filesystem of the program to use to set a label.
  • Clarify examples.

To summarize the original PR:

  • "Labelization" is not a real word. Please change the description of the manual page.
  • glabel(8) is confusing and doesn't distinguish between filesystem labels and GEOM labels.
  • The example doesn't appear to show glabel in action.

PR:262207

Test Plan

Check formatting
mandoc -Tascii lib/geom/label/glabel.8

Check for linter errors:
mandoc -Tlint lib/geom/label/glabel.8

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

felix.the.red_gmail.com edited the summary of this revision. (Show Details)
felix.the.red_gmail.com edited the test plan for this revision. (Show Details)

Remove empty Em.
Remove end-of-line space.

Can you update the patch to use ada instead of ad, which is the more canonical naming used these days?

bcr added a reviewer: felix.the.red_gmail.com.

I'm taking over due to feedback timeout.

Update patch which includes comments and corrections.

I think when this is ready we should consider asking Pawel to review it.

lib/geom/label/glabel.8
30

Nd does not need to be quoted, and is not shown quoted in any style guides.

105

I feel like these paragraphs are out of order somehow, maybe they need subsections also, but please give me a moment to reflect on this.

107โ€“109

We should make this a little clearer about what the table is doing. What does it mean a suitable entry will be created as shown below? The table below says we need to use something else?

110โ€“120

Editorial and mechanical tweaks, but it doesn't make sense to me why /dev/diskid/ and /dev/label/ are not in the table?

293

I kind of hate this. We give them a noun and then in parenthesis three other nouns. We should pick one. Whole entire rest of industry calls these FAT filesystems. By tradition we call them MS-DOS filesystems. Either is clear and concise and fine with me, but trying to define every possible thing in an example is sometime I really try to get people to not do.