copy_file_range: Call vn_rdwr() even for zero-length files
ClosedPublic
Actions

Authored by markj on Jan 20 2024, 5:29 PM.

Details

Reviewers

asomers
kib
rmacklem
olce

Commits

rGe3b27cc3546f: copy_file_range: Call vn_rdwr() at least once
rG08f3d5b60cdf: copy_file_range: Call vn_rdwr() at least once

Summary

This ensures that we invoke VOP_READ on the input file even if it's
empty, which in turn helps ensure that filesystems update the atime of
the file.

PR: 274615

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jan 20 2024, 5:29 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 20 2024, 5:29 PM

markj requested review of this revision.Jan 20 2024, 5:29 PM

Harbormaster completed remote builds in B55512: Diff 133096.Jan 20 2024, 5:29 PM

kib accepted this revision.Jan 20 2024, 6:45 PM

This revision is now accepted and ready to land.Jan 20 2024, 6:45 PM

olce accepted this revision.Jan 20 2024, 8:06 PM

Looks ok to me.

Needs rebasing but passes the additional test from D44609.

des added inline comments.Apr 3 2024, 2:50 PM

sys/kern/vfs_vnops.c
3592	Instead of adding a flag, you could simply switch from while to do-while.

markj added inline comments.Apr 3 2024, 3:39 PM

sys/kern/vfs_vnops.c
3592	It's not that simple - we could have `interrupted != 0` before the first iteration.

Closed by commit rG08f3d5b60cdf: copy_file_range: Call vn_rdwr() at least once (authored by markj). · Explain WhyApr 4 2024, 9:17 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG08f3d5b60cdf: copy_file_range: Call vn_rdwr() at least once.

markj added a commit: rGe3b27cc3546f: copy_file_range: Call vn_rdwr() at least once.May 8 2024, 1:08 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_vnops.c

16 lines

Diff 136548

View Options

copy_file_range: Call vn_rdwr() even for zero-length filesClosedPublicActions