tmpfs: Improve file time tests.
ClosedPublic
Actions

Authored by des on Apr 3 2024, 9:53 AM.

Details

Reviewers

rmacklem
emaste
ngie
markj

Group Reviewers

Klara
tests

Commits

rGe069c451f85e: tmpfs: Improve file time tests.
rG8311bc5f17de: tmpfs: Improve file time tests.

Summary

The empty test case no longer fails because 89f1dcb3eb46 causes empty files to bypass the bug.
The bug still exists, so add a test case which exercises it.
While here, tighten up some of the checks.

A similar patch has been submitted upstream.

PR: 274615
X-MFC-With: 89f1dcb3eb46
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Apr 3 2024, 9:53 AM

Herald added a reviewer: ngie. · View Herald TranscriptApr 3 2024, 9:53 AM

Herald added a subscriber: imp. · View Herald Transcript

des requested review of this revision.Apr 3 2024, 9:53 AM

Harbormaster completed remote builds in B56889: Diff 136468.Apr 3 2024, 9:53 AM

des added a reviewer: tests.Apr 3 2024, 9:58 AM

des mentioned this in D43524: copy_file_range: Call vn_rdwr() even for zero-length files.Apr 3 2024, 2:48 PM

Looks good. I can confirm that this test passes with my patch, will commit shortly.

This revision is now accepted and ready to land.Apr 4 2024, 1:01 PM

Closed by commit rG8311bc5f17de: tmpfs: Improve file time tests. (authored by des). · Explain WhyApr 4 2024, 1:42 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG8311bc5f17de: tmpfs: Improve file time tests..

des added a commit: rGe069c451f85e: tmpfs: Improve file time tests..Apr 9 2024, 8:50 AM

Revision Contents
Changeset List

Path

Size

contrib/

netbsd-tests/

fs/

tmpfs/

t_times.sh

38 lines

Diff 136532

View Options

contrib/netbsd-tests/fs/tmpfs/t_times.sh

tmpfs: Improve file time tests.ClosedPublicActions