sockets: Add hhook in sonewconn for inheriting OSD specific data
ClosedPublic
Actions

Authored by stevek on Apr 4 2024, 12:38 AM.

Details

Reviewers

glebius
tuexen

Commits

rG81b4d1c4d487: sockets: Add hhook in sonewconn for inheriting OSD specific data

Summary

Added HHOOK_SOCKET_NEWCONN and bumped HHOOK_SOCKET_LAST

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56911
Build 53799: arc lint + arc unit

Event Timeline

stevek created this revision.Apr 4 2024, 12:38 AM

Herald added subscribers: olce, imp. · View Herald TranscriptApr 4 2024, 12:38 AM

stevek requested review of this revision.Apr 4 2024, 12:38 AM

Harbormaster completed remote builds in B56911: Diff 136514.Apr 4 2024, 12:38 AM

I was about to ask "where is #ifdef TCP_HHOOKS?" But then I realized that socket_hhh isn't hidden under any ifdef.

Unrelated to this review, but may I ask if it is possible to hide socket_hhh and other stuff that came in 4ec7371233268 under TCP_HHOOKS? Or maybe SOCKET_HHOOKS, if these two are used as two independent features.

This revision is now accepted and ready to land.Apr 4 2024, 3:47 AM

tuexen accepted this revision.Apr 4 2024, 8:05 AM

In D44632#1017491, @glebius wrote:

I was about to ask "where is #ifdef TCP_HHOOKS?" But then I realized that socket_hhh isn't hidden under any ifdef.

Unrelated to this review, but may I ask if it is possible to hide socket_hhh and other stuff that came in 4ec7371233268 under TCP_HHOOKS? Or maybe SOCKET_HHOOKS, if these two are used as two independent features.

I like the idea to put it under an #ifdef.

In D44632#1017491, @glebius wrote:

I was about to ask "where is #ifdef TCP_HHOOKS?" But then I realized that socket_hhh isn't hidden under any ifdef.

Unrelated to this review, but may I ask if it is possible to hide socket_hhh and other stuff that came in 4ec7371233268 under TCP_HHOOKS? Or maybe SOCKET_HHOOKS, if these two are used as two independent features.

I think it should be possibly. I'll look at doing the changes to add option handling to the code.

Closed by commit rG81b4d1c4d487: sockets: Add hhook in sonewconn for inheriting OSD specific data (authored by stevek). · Explain WhyApr 9 2024, 1:34 AM

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rG81b4d1c4d487: sockets: Add hhook in sonewconn for inheriting OSD specific data.