icmp6: rate limit our echo replies
ClosedPublic
Actions

Authored by glebius on Mar 22 2024, 9:49 PM.

Details

Reviewers

tuexen
zlei

Group Reviewers

network

Commits

rGf6561ff8ee10: icmp6: rate limit our echo replies
rG32aeee8ce7e7: icmp6: rate limit our echo replies

Summary

The generation of ICMP6_ECHO_REPLY bypasses icmp6_error(), thus rate
limit was not applied.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Mar 22 2024, 9:49 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptMar 22 2024, 9:49 PM

glebius requested review of this revision.Mar 22 2024, 9:49 PM

Harbormaster completed remote builds in B56751: Diff 136109.Mar 22 2024, 9:49 PM

glebius added a parent revision: D44479: icmp6: make icmp6_ratelimit() responsible to update the stats counter.Mar 22 2024, 9:49 PM

glebius added a child revision: D44481: icmp6: move ICMPv6 related tunables to the files where they are used.

tuexen accepted this revision.Mar 23 2024, 2:21 PM

This revision is now accepted and ready to land.Mar 23 2024, 2:21 PM

Generally looks good to me.

sys/netinet6/icmp6.c
549	And do not forget to update statistic `icp6s_toofreq` if D44479 is abandoned.

Closed by commit rG32aeee8ce7e7: icmp6: rate limit our echo replies (authored by glebius). · Explain WhyMar 24 2024, 4:22 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG32aeee8ce7e7: icmp6: rate limit our echo replies.

zlei added a commit: rGf6561ff8ee10: icmp6: rate limit our echo replies.Wed, Jun 26, 4:52 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

icmp6.c

2 lines

Diff 136164

View Options

icmp6: rate limit our echo repliesClosedPublicActions