Page MenuHomeFreeBSD
Differential D44477

icmp: when logging ICMP ratelimiting message use correct jitter value
ClosedPublic
Actions

Authored by glebius on Mar 22 2024, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 16, 12:11 PM
Unknown Object (File)
Fri, Jan 16, 1:16 AM
Unknown Object (File)
Thu, Jan 15, 7:15 PM
Unknown Object (File)
Thu, Jan 15, 6:03 PM
Unknown Object (File)
Thu, Jan 15, 5:24 PM
Unknown Object (File)
Wed, Jan 14, 9:45 PM
Unknown Object (File)
Mon, Jan 12, 5:24 AM
Unknown Object (File)
Sun, Jan 4, 2:55 PM
View All 100 Files
Subscribers
imp
melifaro
zlei

Details

Reviewers
kp
tuexen
zlei
Group Reviewers
network
Commits
rGb6dc6601559b: icmp: when logging ICMP ratelimiting message use correct jitter value
rGa71eee300ba7: icmp: when logging ICMP ratelimiting message use correct jitter value
rG09a05224b04f: icmp: when logging ICMP ratelimiting message use correct jitter value
rGb508545ce044: icmp: when logging ICMP ratelimiting message use correct jitter value
Summary

The limiting of the very last second has been done using certain jitter
value. We update the jitter for the next second. But the logging should
report the jitter before the change.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56748
Build 53636: arc lint + arc unit

Event Timeline

glebius created this revision.Mar 22 2024, 9:49 PM
Herald added subscribers: melifaro, imp. · View Herald TranscriptMar 22 2024, 9:49 PM
glebius requested review of this revision.Mar 22 2024, 9:49 PM
Harbormaster completed remote builds in B56748: Diff 136106.Mar 22 2024, 9:49 PM
glebius added a parent revision: D44476: icmp: hide icmp_bandlimit_uninit() under VIMAGE.Mar 22 2024, 9:49 PM
glebius added a child revision: D44478: icmp: improve ICMP limit jitter.
glebius added a reviewer: kp.Mar 22 2024, 9:56 PM
kp accepted this revision as: kp.Mar 23 2024, 3:38 AM
This revision is now accepted and ready to land.Mar 23 2024, 3:38 AM
tuexen accepted this revision.Mar 23 2024, 2:17 PM
zlei accepted this revision.Mar 24 2024, 2:12 AM
zlei added a subscriber: zlei.

Looks good to me.

Closed by commit rGb508545ce044: icmp: when logging ICMP ratelimiting message use correct jitter value (authored by glebius). · Explain WhyMar 24 2024, 4:21 PM
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rGb508545ce044: icmp: when logging ICMP ratelimiting message use correct jitter value.
zlei added a commit: rG09a05224b04f: icmp: when logging ICMP ratelimiting message use correct jitter value.Jun 26 2024, 4:51 AM
tuexen added a commit: rGa71eee300ba7: icmp: when logging ICMP ratelimiting message use correct jitter value.Feb 12 2025, 10:23 AM
tuexen added a commit: rGb6dc6601559b: icmp: when logging ICMP ratelimiting message use correct jitter value.Feb 13 2025, 4:46 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
10 lines

Diff 136106

View Options

sys/netinet/ip_icmp.c

Loading...